[jira] [Commented] (GEODE-3953) Lucene create index can fail due to comparison of fieldnames as an array

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238576#comment-16238576 ] 

ASF subversion and git services commented on GEODE-3953:
--------------------------------------------------------

Commit c4697445a400d5bc2d7b490c475471e2f3226a93 in geode's branch refs/heads/feature/GEODE-3953 from [~lhughesgodfrey]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c469744 ]

GEODE-3953: Incorrect use of .equals() for comparison of fieldname arrays
GEODE-3954: Misleading Exception message with mismatched fieldAnalyzers

- corrected equals comparisons of fieldname arrays
- corrected Exception message for mismatched fieldAnalyzers to refer to field analyzers (vs. fieldnames) when remote and local fieldAnalyzers are different sizes
- corrected Exception message to display fieldAnalyzers vs. fieldnames when remote and local fieldAnalyzer maps are different sizes


> Lucene create index can fail due to comparison of fieldnames as an array
> ------------------------------------------------------------------------
>
>                 Key: GEODE-3953
>                 URL: https://issues.apache.org/jira/browse/GEODE-3953
>             Project: Geode
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Shelley Lynn Hughes-Godfrey
>            Assignee: Shelley Lynn Hughes-Godfrey
>
> Note that Arrays.equals() fails if the entries are in a different order ... but order here is not significant and we should not fail the profile comparison
> {noformat}
>     // Verify fields are the same
>     if (!Arrays.equals(remoteProfile.getFieldNames(), getFieldNames())) {
>       return LocalizedStrings.LuceneService_CANNOT_CREATE_INDEX_0_ON_REGION_1_WITH_FIELDS_2_BECAUSE_ANOTHER_MEMBER_DEFINES_THE_SAME_INDEX_WITH_FIELDS_3
>           .toString(getIndexName(), regionPath, Arrays.toString(getFieldNames()),
>               Arrays.toString(remoteProfile.getFieldNames()));
>     }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)