You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/01 20:15:05 UTC

[GitHub] [arrow] ianmcook commented on a change in pull request #9851: ARROW-12155: [R] Require Table columns to be same length

ianmcook commented on a change in pull request #9851:
URL: https://github.com/apache/arrow/pull/9851#discussion_r605919879



##########
File path: r/src/table.cpp
##########
@@ -327,6 +342,8 @@ std::shared_ptr<arrow::Table> Table__from_dots(SEXP lst, SEXP schema_sxp) {
   StopIfNotOk(
       arrow::r::CollectTableColumns(lst, schema, num_fields, infer_schema, columns));
 
+  StopIfNotOk(arrow::r::check_consistent_column_length(columns));

Review comment:
       I believe this will conflict with https://github.com/apache/arrow/pull/9615/ but I believe the resolution is trivial: just insert this line as the second to last line in the new definition of `Table__from_dots`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org