[GitHub] [echarts-bot] pissang commented on a change in pull request #9: feat: check if the title is valid when an issue is opened.

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #9:
URL: https://github.com/apache/echarts-bot/pull/9#discussion_r765849160



##########
File path: src/issue.js
##########
@@ -23,7 +23,12 @@ class Issue {
         const isCore = isCommitter(this.issue.author_association, this.issue.user.login);
 
         if (!isCore) {
-            // avoid opening an issue with no template through `Reference in new issue`
+            // check if the title is valid
+            if (this.isMissingTitle()) {
+                this.addLabels.push(label.MISSING_TITLE);
+                return;
+            }
+            // prevent from opening an issue with no template via `Reference in new issue` button
             if (!this.isUsingTemplate()) {

Review comment:
       I think we can disable template keyword based template checking temporary to avoid bot closing the issue(and forget why) unexpectedly when we change the template in the future. But we can still pay attention if there are invalid issue that not follow the template




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org