You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/08/14 13:57:46 UTC
[PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
jorisvandenbossche opened a new pull request, #43691:
URL: https://github.com/apache/arrow/pull/43691
### Rationale for this change
The current [requirements-wheel-test.txt](https://github.com/apache/arrow/blob/7c8909a144f2e8d593dc8ad363ac95b2865b04ca/python/requirements-wheel-test.txt) file has quite complex and detailed version pinning, varying per architecture. I think this can be simplified because we just want to test with some older version of numpy and pandas (and the exact version isn't that important).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2289193777
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2288834784
:warning: GitHub issue #43690 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1725529655
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,12 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+# We generally test with the oldest numpy version that supports a given Python
+# version. However, there is no need to make this strictly the oldest version,
+# so it can be broadened to have a single version specification across platforms.
+# (`~=x.y.z` specifies a compatible release as `>=x.y.z, == x.y.*`)
+numpy~=1.21.3; python_version < "3.11"
Review Comment:
The numpy support table says Python 3.10 supports Numpy 1.23+, while Python 3.9 supports Numpy 1.21+. Is it worth breaking these apart?
https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1726543311
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,12 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+# We generally test with the oldest numpy version that supports a given Python
+# version. However, there is no need to make this strictly the oldest version,
+# so it can be broadened to have a single version specification across platforms.
+# (`~=x.y.z` specifies a compatible release as `>=x.y.z, == x.y.*`)
+numpy~=1.21.3; python_version < "3.11"
Review Comment:
I think that table is a recommendation about the versions to support for other projects (that rely on Python and numpy), not necessarily the Python/numpy version that supports each other.
So if I interpret it correctly, my reading is that, for example, at Apr 05, 2024, it is recommended to support Python 3.10+ and NumPy 1.23+.
But for the oldest NumPy version to support Python 3.10, I looked at the release notes, for example https://numpy.org/doc/stable/release/1.21.3-notes.html indicates it is the first version to support 3.10
In theory we could pin to an older version of numpy for Python 3.9 (https://numpy.org/doc/stable/release/1.19.3-notes.html), but the problem is that then we need to start using a different version depending on the architecture, because at the time numpy first supported Python 3.9 (numpy 1.19.3), there were not yet arm64 wheels.
Given it is not super critical to test exactly with the oldest, but we mostly want to test with some other version than what we are building with (which is nowadays the most recent numpy version), I decided to keep the version pins simpler (as explained in the comment that I added to the txt file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1717177216
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,8 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+numpy==1.21.3; python_version < "3.11"
+numpy==1.23.5; python_version == "3.11"
+numpy==1.26.4; python_version == "3.12"
Review Comment:
The only difference here is that for non-arm archs, we used numpy 1.19 instead of numpy 1.21 for python < 3.11. But given this is just to test, we can simplify to test with numpy 1.21 for all architectures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1722857340
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,8 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+numpy~=1.21.3; python_version < "3.11"
+numpy~=1.23.2; python_version == "3.11"
+numpy~=1.26.0; python_version == "3.12"
Review Comment:
> How is `~=` different from `==` in requirements file?
I was initially using `==` as before, but after reading https://packaging.python.org/en/latest/specifications/version-specifiers/#id5 I thought this was the best option (although I would also have to look it up again, which makes it not ideal maintenance-wise, maybe I should add a comment explaining the logic).
The `~=` is called a "compatible" release, and essentially `numpy~=1.26.0` translates to `>= 1.26.0, == 1.26.*`. Using this instead of `==` avoids us bumping those exact pins to the latest bug-fix release in that x.y series, as we sometimes did in the past ([example](https://github.com/apache/arrow/commit/721aa019aa0cb3b6a15aa358a53f39e2c5c541ae#diff-3385c98e15ee29eedc051bdefb0755af30f4d882ff0038ce1a46f677c505ac78))
> Also, should be include a line for Python 3.13?
I had removed that again because it is being added in https://github.com/apache/arrow/pull/43539 (anyway, depending on which PR is merged first, the other will have to fix the conflicts for this file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1727089683
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,12 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+# We generally test with the oldest numpy version that supports a given Python
+# version. However, there is no need to make this strictly the oldest version,
+# so it can be broadened to have a single version specification across platforms.
+# (`~=x.y.z` specifies a compatible release as `>=x.y.z, == x.y.*`)
+numpy~=1.21.3; python_version < "3.11"
Review Comment:
That makes sense. Your changes look good as-is. Thanks for sharing your approach!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1717174276
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,8 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+numpy==1.21.3; python_version < "3.11"
+numpy==1.23.5; python_version == "3.11"
+numpy==1.26.4; python_version == "3.12"
-pandas<1.1.0; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.8"
-pandas; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.8"
-pandas; platform_system == "Linux" and platform_machine == "aarch64"
-pandas<1.1.0; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.8"
-pandas; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.8"
-pandas; platform_system == "Darwin" and platform_machine == "arm64"
-pandas<1.1.0; platform_system == "Windows" and python_version < "3.8"
-pandas; platform_system == "Windows" and python_version >= "3.8"
+pandas
Review Comment:
Essentially we were already asking for just `pandas` for everything not below 3.8, and we don't support such old python version anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2288834605
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1721465232
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,8 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+numpy~=1.21.3; python_version < "3.11"
+numpy~=1.23.2; python_version == "3.11"
+numpy~=1.26.0; python_version == "3.12"
Review Comment:
Also, should be include a line for Python 3.13?
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,8 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+numpy~=1.21.3; python_version < "3.11"
+numpy~=1.23.2; python_version == "3.11"
+numpy~=1.26.0; python_version == "3.12"
Review Comment:
How is `~=` different from `==` in requirements file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #43691:
URL: https://github.com/apache/arrow/pull/43691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1725531748
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,12 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+# We generally test with the oldest numpy version that supports a given Python
+# version. However, there is no need to make this strictly the oldest version,
+# so it can be broadened to have a single version specification across platforms.
+# (`~=x.y.z` specifies a compatible release as `>=x.y.z, == x.y.*`)
+numpy~=1.21.3; python_version < "3.11"
Review Comment:
Ehh, maybe I'm not reading that support matrix correctly..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on code in PR #43691:
URL: https://github.com/apache/arrow/pull/43691#discussion_r1722867991
##########
python/requirements-wheel-test.txt:
##########
@@ -5,22 +5,8 @@ pytest
pytz
tzdata; sys_platform == 'win32'
-numpy==1.21.3; platform_system == "Linux" and platform_machine == "aarch64" and python_version < "3.11"
-numpy==1.23.4; python_version == "3.11"
-numpy==1.26.0; python_version >= "3.12"
-numpy==1.19.5; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine == "arm64" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.9" and python_version < "3.11"
-numpy==1.19.5; platform_system == "Windows" and python_version < "3.9"
-numpy==1.21.3; platform_system == "Windows" and python_version >= "3.9" and python_version < "3.11"
+numpy~=1.21.3; python_version < "3.11"
+numpy~=1.23.2; python_version == "3.11"
+numpy~=1.26.0; python_version == "3.12"
Review Comment:
Added a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2289199012
Revision: 7507e9ebdd89274889e9390dbedb6f219b04df67
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b57c649d6a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b57c649d6a)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390990034/job/28772805286)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989541/job/28772802315)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989536/job/28772802685)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989192/job/28772800660)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989949/job/28772804938)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989807/job/28772804084)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989618/job/28772802547)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989347/job/28772801413)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989421/job/28772801865)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989742/job/28772803500)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989659/job/28772802975)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989707/job/28772803470)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989321/job/28772801259)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989180/job/28772800671)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989855/job/28772804347)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989738/job/28772803743)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989967/job/28772805052)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390990020/job/28772805275)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390990427/job/28772806187)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989592/job/28772802703)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390990100/job/28772805556)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989783/job/28772803811)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989488/job/28772802293)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989909/job/28772804719)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989361/job/28772801488)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989741/job/28772803894)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989341/job/28772801173)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989194/job/28772800647)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989856/job/28772804268)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989597/job/28772802859)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989886/job/28772804434)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390990096/job/28772805801)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989658/job/28772803349)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390989281/job/28772801128)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10390990078/job/28772805531)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2288844611
Revision: 035304ff635e0ea6bc4afce90c95073f8451a15e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9813ca3702](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9813ca3702)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025249/job/28766068723)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025246/job/28766068747)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025058/job/28766067107)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025632/job/28766072070)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025495/job/28766071132)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025042/job/28766067144)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025451/job/28766070775)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025049/job/28766067174)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025604/job/28766071694)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025200/job/28766068647)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025772/job/28766072566)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389024993/job/28766067064)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025866/job/28766073439)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025166/job/28766068150)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025124/job/28766067859)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025287/job/28766069479)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025381/job/28766070116)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025851/job/28766073310)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025313/job/28766069240)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025447/job/28766069955)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025441/job/28766070028)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025736/job/28766072489)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025080/job/28766067593)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025412/job/28766069750)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025628/job/28766072057)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025390/job/28766069764)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025536/job/28766071337)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025247/job/28766069098)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025555/job/28766071588)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025766/job/28766072852)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025717/job/28766072774)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025435/job/28766070752)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025326/job/28766070368)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025703/job/28766072224)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/10389025484/job/28766070963)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2289149819
Leaving the python 3.13 specific ones for https://github.com/apache/arrow/pull/43539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2304022003
Going to merge this, so I can update https://github.com/apache/arrow/pull/43539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43690: [Python][CI] Simplify python/requirements-wheel-test.txt file [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43691:
URL: https://github.com/apache/arrow/pull/43691#issuecomment-2305100694
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2e83aa63d95a6fa380efdd5e5cb720a3154f9c93.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/29122365951) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org