Re: [PR] GH-37318: [Python]: Optimize combine_chunks when there is only one chunk [arrow]

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on PR #37319:
URL: https://github.com/apache/arrow/pull/37319#issuecomment-1748816009

   Nothing, just pinging like you did! Sorry for the slow follow-up. 
   
   I was planning to merge it since I already approved it earlier, but then I thought of the following potential issue: one side-effect of this optimization is that this no longer copies the single-chunk case, but therefore also no longer reduces the memory in case this one chunk consists of a sliced array. See https://github.com/apache/arrow/issues/37878 for some context. 
   So the concat call can actually also have a beneficial side effect .. (but it's difficult to know which optimization is most important depending on the use case)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org