You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/26 22:19:31 UTC

[GitHub] [trafficcontrol] rob05c opened a new issue #5892: Fix Cache Config Generation for UrlSig to add necessary Parameters if they don't exist.

rob05c opened a new issue #5892:
URL: https://github.com/apache/trafficcontrol/issues/5892


   Currently, if magic Parameters for URLSig don't exist, url_sig.so and remap.config will fail to reload. At least `error_url`, possibly also `excl_regex` and `sig_anchor = urlsig`. 
   
   We should make the Cache Config Generation for URLSig insert these necessary strings if they don't exist, and log a warning.
   
   One DS should never be able to cause the CDN to fail, or fail to load new config. We could also remove the DS line from remap.config. But most users probably don't care about the parameters, it's easy enough to add them to make the DS succeed.
   
   Generation code is here: https://github.com/apache/trafficcontrol/blob/master/lib/go-atscfg/urlsigconfig.go
   
   ## I'm submitting a ...
   -  improvement request (usability, performance, tech debt, etc.)
   
   ## Traffic Control components affected ...
   -  Traffic Ops ORT
   
   ## Current behavior:
   Creating a Delivery Service with URLSig without magic Parameters will cause remap.config to fail to load.
   
   ## New behavior:
   Creating a Delivery Service with URLSig without magic Parameters will cause config generation to insert necessary parameters in url_sig_dsname.config, so remap.config loads and the Delivery Service works.
   
   ## Minimal reproduction of the problem with instructions:
   Create a Delivery Service with URLSig without magic Parameters.
   
   ## Anything else:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org