You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by jo...@apache.org on 2016/06/29 08:33:12 UTC
zeppelin git commit: [Bugfix] init RepoSetting values
Repository: zeppelin
Updated Branches:
refs/heads/master 6f434c561 -> d4e3d8cf0
[Bugfix] init RepoSetting values
### What is this PR for?
This PR fixes initialize value bug of ```Add New Repository```.
### What type of PR is it?
Bug Fix
### How should this be tested?
1. launch the ```Add New Repository``` modal window.
2. put URL value
3. hit Cancel button
4. launch the ```Add New Repository``` modal window again.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: astroshim <hs...@nflabs.com>
Closes #1097 from astroshim/bugfix/initRepositoryValues and squashes the following commits:
f5a08d5 [astroshim] init newRepoSetting values
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/d4e3d8cf
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/d4e3d8cf
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/d4e3d8cf
Branch: refs/heads/master
Commit: d4e3d8cf05e75fc1920dd6419c7c2f41b34ff08e
Parents: 6f434c5
Author: astroshim <hs...@nflabs.com>
Authored: Tue Jun 28 02:08:47 2016 +0900
Committer: Jongyoul Lee <jo...@apache.org>
Committed: Wed Jun 29 17:32:59 2016 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/interpreter/interpreter.controller.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d4e3d8cf/zeppelin-web/src/app/interpreter/interpreter.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.controller.js b/zeppelin-web/src/app/interpreter/interpreter.controller.js
index 8610910..d787238 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.controller.js
+++ b/zeppelin-web/src/app/interpreter/interpreter.controller.js
@@ -389,11 +389,11 @@ angular.module('zeppelinWebApp').controller('InterpreterCtrl', function($scope,
$scope.resetNewRepositorySetting = function() {
$scope.newRepoSetting = {
- id: undefined,
- url: undefined,
+ id: '',
+ url: '',
snapshot: false,
- username: undefined,
- password: undefined
+ username: '',
+ password: ''
};
};