[GitHub] [superset] geido commented on pull request #13513: test: Tests, dedicated directory and storybook for the Badge component

[GitBox <gi...@apache.org>]

geido commented on pull request #13513:
URL: https://github.com/apache/superset/pull/13513#issuecomment-793003823


   > @geido Code LGTM. One thing that I noticed is that if I change the values of `count`, `color`, `textColor` and `size` in the storybook, nothing happens. Are these properties not used?
   
   @michael-s-molina some properties are exclusive. For instance, you should not use the property count together with the property text or the property status with color. That is the reason why I added undefined to the options so all the combinations can be tested exclusively. However, if you think there is a better way to achieve that, I'll be happy to revisit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org