You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2018/02/02 15:39:13 UTC
[GitHub] drill pull request #1108: DRILL-6130: Fix NPE during physical plan submissio...
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/1108
DRILL-6130: Fix NPE during physical plan submission for various storage plugins
1. Fixed ser / de issues for Hive, Kafka, Hbase plugins.
2. Added physical plan submission unit test for all storage plugins in contrib module.
3. Refactoring.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill DRILL-6130
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1108
----
commit aabd11cc327100d248b22b72d9696d8911545d75
Author: Arina Ielchiieva <ar...@...>
Date: 2018-02-01T17:44:43Z
DRILL-6130: Fix NPE during physical plan submission for various storage plugins
1. Fixed ser / de issues for Hive, Kafka, Hbase plugins.
2. Added physical plan submission unit test for all storage plugins in contrib module.
3. Refactoring.
----
---
[GitHub] drill issue #1108: DRILL-6130: Fix NPE during physical plan submission for v...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1108
@vdiravka thanks for the code review. Addressed two comments.
---
[GitHub] drill pull request #1108: DRILL-6130: Fix NPE during physical plan submissio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1108
---
[GitHub] drill pull request #1108: DRILL-6130: Fix NPE during physical plan submissio...
Posted by vdiravka <gi...@git.apache.org>.
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1108#discussion_r166468585
--- Diff: contrib/storage-kudu/src/main/java/org/apache/drill/exec/store/kudu/KuduSubScan.java ---
@@ -143,7 +133,7 @@ public String getTableName() {
@Override
public int getOperatorType() {
- return CoreOperatorType.HBASE_SUB_SCAN_VALUE;
+ return -1;
--- End diff --
Can we add `KUDU_SUB_SCAN_VALUE` to `CoreOperatorType` and use here?
---
[GitHub] drill pull request #1108: DRILL-6130: Fix NPE during physical plan submissio...
Posted by vdiravka <gi...@git.apache.org>.
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1108#discussion_r166727342
--- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java ---
@@ -175,9 +175,8 @@ public void testBasicQueryWithNonExistentTableName() throws Exception {
@Test
public void testPhysicalPlanExecutionBasedOnQuery() throws Exception {
--- End diff --
testPhysicalPlanExecutionBasedOnQuery -> testPhysicalPlanSubmission
---
[GitHub] drill issue #1108: DRILL-6130: Fix NPE during physical plan submission for v...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1108
@vdiravka please review.
---