You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Joel Klein (JIRA)" <ji...@apache.org> on 2007/11/14 19:11:43 UTC

[jira] Created: (DAEMON-106) prunsrv.exe //US// always returns exit code 6, even if successful

prunsrv.exe //US// always returns exit code 6, even if successful
-----------------------------------------------------------------

                 Key: DAEMON-106
                 URL: https://issues.apache.org/jira/browse/DAEMON-106
             Project: Commons Daemon
          Issue Type: Bug
    Affects Versions: 1.0.1
         Environment: Windows
            Reporter: Joel Klein
            Priority: Minor


When using tomcat6.exe from https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/res/procrun/, the //US// command always returns 6:

tomcat6.exe //US//servicename --Startup=auto

returns exit code 6 even though the command successfully changed the service Startup Type to auto.

>From the source code, it looks as if docmdUpdateService just never sets the variable rv to TRUE anywhere, and the only return statements are "return FALSE" (when the code can't get a handle to the service) and return rv at the end.

When we invoke this from our software's installer, we'd like to be able to check the exit code and trust whether it means success or failure, but as it stands we have to not check the exit code or check things other than the exit code to test for success.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DAEMON-106) prunsrv.exe //US// always returns exit code 6, even if successful

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DAEMON-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated DAEMON-106:
------------------------

    Fix Version/s: 1.0.2

> prunsrv.exe //US// always returns exit code 6, even if successful
> -----------------------------------------------------------------
>
>                 Key: DAEMON-106
>                 URL: https://issues.apache.org/jira/browse/DAEMON-106
>             Project: Commons Daemon
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>         Environment: Windows
>            Reporter: Joel Klein
>            Priority: Minor
>             Fix For: 1.0.2
>
>         Attachments: DAEMON-106_Jack.patch
>
>
> When using tomcat6.exe from https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/res/procrun/, the //US// command always returns 6:
> tomcat6.exe //US//servicename --Startup=auto
> returns exit code 6 even though the command successfully changed the service Startup Type to auto.
> From the source code, it looks as if docmdUpdateService just never sets the variable rv to TRUE anywhere, and the only return statements are "return FALSE" (when the code can't get a handle to the service) and return rv at the end.
> When we invoke this from our software's installer, we'd like to be able to check the exit code and trust whether it means success or failure, but as it stands we have to not check the exit code or check things other than the exit code to test for success.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DAEMON-106) prunsrv.exe //US// always returns exit code 6, even if successful

Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DAEMON-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jack Cai updated DAEMON-106:
----------------------------

    Attachment: DAEMON-106_Jack.patch

Attaching a fix. Test passed.

> prunsrv.exe //US// always returns exit code 6, even if successful
> -----------------------------------------------------------------
>
>                 Key: DAEMON-106
>                 URL: https://issues.apache.org/jira/browse/DAEMON-106
>             Project: Commons Daemon
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>         Environment: Windows
>            Reporter: Joel Klein
>            Priority: Minor
>         Attachments: DAEMON-106_Jack.patch
>
>
> When using tomcat6.exe from https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/res/procrun/, the //US// command always returns 6:
> tomcat6.exe //US//servicename --Startup=auto
> returns exit code 6 even though the command successfully changed the service Startup Type to auto.
> From the source code, it looks as if docmdUpdateService just never sets the variable rv to TRUE anywhere, and the only return statements are "return FALSE" (when the code can't get a handle to the service) and return rv at the end.
> When we invoke this from our software's installer, we'd like to be able to check the exit code and trust whether it means success or failure, but as it stands we have to not check the exit code or check things other than the exit code to test for success.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DAEMON-106) prunsrv.exe //US// always returns exit code 6, even if successful

Posted by "EBIHARA, Yuichiro (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DAEMON-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623537#action_12623537 ] 

EBIHARA, Yuichiro commented on DAEMON-106:
------------------------------------------

I'm meeting the same issue.

'saveConfiguration' function returns a BOOL value and I believe it should be returned as the return value of 'docmdUpdateService' function.

> prunsrv.exe //US// always returns exit code 6, even if successful
> -----------------------------------------------------------------
>
>                 Key: DAEMON-106
>                 URL: https://issues.apache.org/jira/browse/DAEMON-106
>             Project: Commons Daemon
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>         Environment: Windows
>            Reporter: Joel Klein
>            Priority: Minor
>
> When using tomcat6.exe from https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/res/procrun/, the //US// command always returns 6:
> tomcat6.exe //US//servicename --Startup=auto
> returns exit code 6 even though the command successfully changed the service Startup Type to auto.
> From the source code, it looks as if docmdUpdateService just never sets the variable rv to TRUE anywhere, and the only return statements are "return FALSE" (when the code can't get a handle to the service) and return rv at the end.
> When we invoke this from our software's installer, we'd like to be able to check the exit code and trust whether it means success or failure, but as it stands we have to not check the exit code or check things other than the exit code to test for success.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DAEMON-106) prunsrv.exe //US// always returns exit code 6, even if successful

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DAEMON-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved DAEMON-106.
-------------------------

    Resolution: Fixed

URL: http://svn.apache.org/viewvc?rev=897075&view=rev
Log:
DAEMON-106 prunsrv.exe //US// always returns exit code 6, even if successful


> prunsrv.exe //US// always returns exit code 6, even if successful
> -----------------------------------------------------------------
>
>                 Key: DAEMON-106
>                 URL: https://issues.apache.org/jira/browse/DAEMON-106
>             Project: Commons Daemon
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>         Environment: Windows
>            Reporter: Joel Klein
>            Priority: Minor
>         Attachments: DAEMON-106_Jack.patch
>
>
> When using tomcat6.exe from https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/res/procrun/, the //US// command always returns 6:
> tomcat6.exe //US//servicename --Startup=auto
> returns exit code 6 even though the command successfully changed the service Startup Type to auto.
> From the source code, it looks as if docmdUpdateService just never sets the variable rv to TRUE anywhere, and the only return statements are "return FALSE" (when the code can't get a handle to the service) and return rv at the end.
> When we invoke this from our software's installer, we'd like to be able to check the exit code and trust whether it means success or failure, but as it stands we have to not check the exit code or check things other than the exit code to test for success.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.