[Bug 7466] New: Fixes for Bug #6945 break the ability for rules to match based on attachment name

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7466

            Bug ID: 7466
           Summary: Fixes for Bug #6945 break the ability for rules to
                    match based on attachment name
           Product: Spamassassin
           Version: 3.4.0
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Libraries
          Assignee: dev@spamassassin.apache.org
          Reporter: shaun@linuxmagic.com
  Target Milestone: Undefined

Looking over the changes that were made for #6945 - I get it - I understand it
- but unfortunately this has proven to break the ability for rules to be made
that target file name patterns (eg: files ending with .docm or similar).  I
note that upstream sa-update rules have several of these patterns as well that
are similarly being defeated by UTF encoding the file name.

Suggest that instead of having function _decode_header skip the Content-
headers, that the original bug should possibly have changed the mechanism of
how sa-learn works - for example - there is already a stored array of the 'raw'
headers in the Message Node object that are available for sa-learn to operate
from without having to taint the results of the 'decoded' header values.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7466] Fixes for Bug #6945 break the ability for rules to match based on attachment name

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7466

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Karsten Bräckelmann <gu...@rudersport.de> ---
Thanks for the confirmation, Shaun. Closing RESOLVED FIXED.

Decoding of Content-* headers should not cause a regression with bug 6945,
which really is about non-ASCII chars in the Message-ID only. The decoding of
Content-* headers is unrelated, and should not have been disabled in the first
place unlike e.g. for Message-ID and Received headers. This has already been
reverted in trunk, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7466] Fixes for Bug #6945 break the ability for rules to match based on attachment name

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7466

Shaun Johnson <sh...@linuxmagic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shaun@linuxmagic.com

--- Comment #3 from Shaun Johnson <sh...@linuxmagic.com> ---
That does indeed fix the issue - just curious however if that removal of the
Content- exclusions might not cause a regression with the original bug related
to sa-learn?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7466] Fixes for Bug #6945 break the ability for rules to match based on attachment name

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7466

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@apache.org

--- Comment #1 from Kevin A. McGrail <km...@apache.org> ---
Can you provide specific examples of rules with problems?

Are you testing with and without normalize_charset 1?

It's also most helpful to submit patches or at least a framework of a fix. 

KAM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7466] Fixes for Bug #6945 break the ability for rules to match based on attachment name

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7466

--- Comment #2 from Karsten Bräckelmann <gu...@rudersport.de> ---
This appears to have been fixed with bug 7249 in trunk.

Rather than backporting commit revision 1707593 and its siblings in full, just
reverting the bit for Content-* header seems appropriate for the stable 3.4
branch.

Sending        Node.pm
Committed revision 1806756.

Shaun, can you confirm this fixes your issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.