[jira] [Commented] (AMBARI-22473) shell.process_executor races process exit

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-22473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258829#comment-16258829 ] 

Hadoop QA commented on AMBARI-22473:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12898369/0001-AMBARI-22473-shell.process_executor-races-process-ex.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/12689//console

This message is automatically generated.

> shell.process_executor races process exit
> -----------------------------------------
>
>                 Key: AMBARI-22473
>                 URL: https://issues.apache.org/jira/browse/AMBARI-22473
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Jonathan Matthew
>         Attachments: 0001-AMBARI-22473-shell.process_executor-races-process-ex.patch
>
>
> By calling cmd.poll(), shell.process_executor assumes that the subcommand will have exited once it has finished reading from its stdout pipe. This isn't necessarily the case, so it should call cmd.wait() instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)