You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/03/15 22:19:58 UTC
[GitHub] [trafficserver] maskit opened a new pull request, #9525: Fix compile warning on BoringSSL build
maskit opened a new pull request, #9525:
URL: https://github.com/apache/trafficserver/pull/9525
Same as code below:
https://github.com/apache/trafficserver/blob/c54a2e2b77151869ff014fbdc4c82cec0afcbb8c/tests/tools/plugins/ssl_client_verify_test.cc#L116-L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #9525: Fix compile warning on BoringSSL build
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #9525:
URL: https://github.com/apache/trafficserver/pull/9525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9525: Fix compile warning on BoringSSL build
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on code in PR #9525:
URL: https://github.com/apache/trafficserver/pull/9525#discussion_r1137856611
##########
iocore/net/OCSPStapling.cc:
##########
@@ -130,7 +130,7 @@ stapling_get_issuer(SSL_CTX *ssl_ctx, X509 *x)
goto end;
}
- for (int i = 0; i < sk_X509_num(extra_certs); i++) {
+ for (int i = 0; i < static_cast<int>(sk_X509_num(extra_certs)); i++) {
Review Comment:
Why cast, rather than changing `int` to the correct type? If you wanted to annoying Leif, you could even do
```
for ( decltype(sk_X509_num(extra_certs) i = 0 ; ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9525: Fix compile warning on BoringSSL build
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9525:
URL: https://github.com/apache/trafficserver/pull/9525#issuecomment-1472250636
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a diff in pull request #9525: Fix compile warning on BoringSSL build
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #9525:
URL: https://github.com/apache/trafficserver/pull/9525#discussion_r1138210565
##########
iocore/net/OCSPStapling.cc:
##########
@@ -130,7 +130,7 @@ stapling_get_issuer(SSL_CTX *ssl_ctx, X509 *x)
goto end;
}
- for (int i = 0; i < sk_X509_num(extra_certs); i++) {
+ for (int i = 0; i < static_cast<int>(sk_X509_num(extra_certs)); i++) {
Review Comment:
https://godbolt.org/z/GPTGacGGc
You like to do things in inconsistent ways?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9525: Fix compile warning on BoringSSL build
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on code in PR #9525:
URL: https://github.com/apache/trafficserver/pull/9525#discussion_r1138860171
##########
iocore/net/OCSPStapling.cc:
##########
@@ -130,7 +130,7 @@ stapling_get_issuer(SSL_CTX *ssl_ctx, X509 *x)
goto end;
}
- for (int i = 0; i < sk_X509_num(extra_certs); i++) {
+ for (int i = 0; i < static_cast<int>(sk_X509_num(extra_certs)); i++) {
Review Comment:
No, `decltype` was added to deal with this kind of situation.
[Example on godbolt](https://godbolt.org/#g:!((g:!((g:!((h:codeEditor,i:(filename:'1',fontScale:14,fontUsePx:'0',j:1,lang:c%2B%2B,selection:(endColumn:1,endLineNumber:14,positionColumn:1,positionLineNumber:14,selectionStartColumn:1,selectionStartLineNumber:14,startColumn:1,startLineNumber:14),source:'%23include+%3Cstddef.h%3E%0A%0Asize_t+bssl()+%7B%0A++++return+0%3B%0A%7D%0A%0Aint+ossl()+%7B%0A++++return+0%3B%0A%7D%0A%0Aint+main(int,+char+**)+%7B%0A++++for+(+decltype(bssl())+i+%3D+0%3B+i+%3C+bssl()+%3B+%2B%2Bi)%0A++++%3B%0A++++for+(+decltype(ossl())+i+%3D+0%3B+i+%3C+ossl()+%3B+%2B%2Bi)%0A++++%3B%0A%7D'),l:'5',n:'0',o:'C%2B%2B+source+%231',t:'0')),k:50.564466055430586,l:'4',n:'0',o:'',s:0,t:'0'),(g:!((g:!((h:output,i:(compilerName:'x86-64+gcc+8.3',editorid:1,fontScale:14,fontUsePx:'0',j:1,wrap:'1'),l:'5',n:'0',o:'Output+of+x86-64+gcc+12.2+(Compiler+%231)',t:'0')),k:49.15330091685415,l:'4',m:53.125,n:'0',o:'',s:0,t:'0'),(g:!((h:compiler,i:(compiler:g122,deviceViewOpen:'1',filters:(b
:'0',binary:'1',binaryObject:'1',commentOnly:'0',demangle:'0',directives:'0',execute:'1',intel:'1',libraryCode:'1',trim:'1'),flagsViewOpen:'1',fontScale:14,fontUsePx:'0',j:1,lang:c%2B%2B,libs:!(),options:'-pedantic+-Wall+-Wextra++-std%3Dc%2B%2B17+-O3',selection:(endColumn:1,endLineNumber:1,positionColumn:1,positionLineNumber:1,selectionStartColumn:1,selectionStartLineNumber:1,startColumn:1,startLineNumber:1),source:1),l:'5',n:'0',o:'+x86-64+gcc+12.2+(Editor+%231)',t:'0')),header:(),l:'4',m:46.875,n:'0',o:'',s:0,t:'0')),k:49.435533944569436,l:'3',n:'0',o:'',t:'0')),l:'2',n:'0',o:'',t:'0')),version:4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9525: Fix compile warning on BoringSSL build
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9525:
URL: https://github.com/apache/trafficserver/pull/9525#issuecomment-1472396496
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org