You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "norm (via GitHub)" <gi...@apache.org> on 2023/02/02 13:29:38 UTC

[GitHub] [airflow] norm commented on a diff in pull request #29309: Add `airflow db drop-archived` command

norm commented on code in PR #29309:
URL: https://github.com/apache/airflow/pull/29309#discussion_r1094533045


##########
airflow/cli/commands/db_command.py:
##########
@@ -218,3 +218,12 @@ def export_cleaned(args):
         table_names=args.tables,
         drop_archives=args.drop_archives,
     )
+
+
+@cli_utils.action_cli(check_db=False)
+def drop_archived(args):
+    """Drops archived tables from metadata database."""
+    drop_archived_tables(
+        table_names=args.tables,
+        confirm=not args.yes,

Review Comment:
   Can you rename this to something like `needs_confirm` or `manual_confirm` — because in my head using `-y` means you have confirmed it and it just reads … wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org