You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/04/14 22:20:32 UTC

[native-toolchain-CR] IMPALA-11282: Fix Centos8 docker build by using vault repository

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19747


Change subject: IMPALA-11282: Fix Centos8 docker build by using vault repository
......................................................................

IMPALA-11282: Fix Centos8 docker build by using vault repository

Centos 8 stopped maintaining its regular yum repositories
as part of the switch to Centos Stream. This switches the
Docker build for the Centos 8 docker image to use the vault
repositories for Centos 8.2.2004, which matches the version
of the docker image we use.

Testing:
 - Built Centos 8 docker image

Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
---
A docker/redhat/CentOS-8.2.2004-AppStream.repo
A docker/redhat/CentOS-8.2.2004-Base.repo
A docker/redhat/CentOS-8.2.2004-Extras.repo
M docker/redhat8.df
4 files changed, 44 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/47/19747/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
Gerrit-Change-Number: 19747
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] IMPALA-11282: Fix Centos8 docker build by using vault repository

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19747 )

Change subject: IMPALA-11282: Fix Centos8 docker build by using vault repository
......................................................................

IMPALA-11282: Fix Centos8 docker build by using vault repository

Centos 8 stopped maintaining its regular yum repositories
as part of the switch to Centos Stream. This switches the
Docker build for the Centos 8 docker image to use the vault
repositories for Centos 8.2.2004, which matches the version
of the docker image we use.

Testing:
 - Built Centos 8 docker image

Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
Reviewed-on: http://gerrit.cloudera.org:8080/19747
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
A docker/redhat/CentOS-8.2.2004-AppStream.repo
A docker/redhat/CentOS-8.2.2004-Base.repo
A docker/redhat/CentOS-8.2.2004-Extras.repo
M docker/redhat8.df
4 files changed, 44 insertions(+), 0 deletions(-)

Approvals:
  Michael Smith: Looks good to me, approved
  Joe McDonnell: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
Gerrit-Change-Number: 19747
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[native-toolchain-CR] IMPALA-11282: Fix Centos8 docker build by using vault repository

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19747 )

Change subject: IMPALA-11282: Fix Centos8 docker build by using vault repository
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
Gerrit-Change-Number: 19747
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 15 Apr 2023 22:57:32 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-11282: Fix Centos8 docker build by using vault repository

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19747 )

Change subject: IMPALA-11282: Fix Centos8 docker build by using vault repository
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
Gerrit-Change-Number: 19747
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 21:49:46 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-11282: Fix Centos8 docker build by using vault repository

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19747 )

Change subject: IMPALA-11282: Fix Centos8 docker build by using vault repository
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
Gerrit-Change-Number: 19747
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Apr 2023 18:37:12 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-11282: Fix Centos8 docker build by using vault repository

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19747 )

Change subject: IMPALA-11282: Fix Centos8 docker build by using vault repository
......................................................................


Patch Set 1: Code-Review+1

Seems like kind of a short-term patch. But fine for the moment.


-- 
To view, visit http://gerrit.cloudera.org:8080/19747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc362763923f095002b9ce56e7defdd35273896
Gerrit-Change-Number: 19747
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Apr 2023 22:22:09 +0000
Gerrit-HasComments: No