You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/13 05:49:03 UTC
[GitHub] [incubator-kvrocks] ShooterIT created a discussion: Only saying 'closes #issue' in PR is not enough
GitHub user ShooterIT created a discussion: Only saying 'closes #issue' in PR is not enough
I found recent PRs only say 'closes #xxx', i don't think it is enough, the issue maybe only describe `why` we should do things or there is a bug. But in the PR, we need to describe not only the problem but also the solution, even the pros and cons, and we should add these informations in comment log.
GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
[GitHub] [incubator-kvrocks] tisonkun added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
Posted by GitBox <gi...@apache.org>.
GitHub user tisonkun added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
@ShooterIT If you find a specific PR without sufficient information/description, you as a committer can send a request changes review.
For some trivial changes like fix a typo or finish a subtasks whose tracking issue is clear defined (migrating tests, fixing clang-clippy linter), it needs not redundant description.
The GitHub-provided PULL_REQUEST_TEMPLATE mechanism can always grow too cumbersome to follow. I don't see a good practice for it - finally, most contributors omit it.
GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179#discussioncomment-4386296
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
[GitHub] [incubator-kvrocks] tisonkun added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
Posted by GitBox <gi...@apache.org>.
GitHub user tisonkun added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
Also, review after merge can help to spread consensus. If a PR goes through a wrong process in your opinion, commenting on it under the thread is encouraged.
GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179#discussioncomment-4386356
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
[GitHub] [incubator-kvrocks] DonnaBaker3532 added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
Posted by GitBox <gi...@apache.org>.
GitHub user DonnaBaker3532 added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
Awesome chicks are waiting for you https://4.fo/q8SFZGT
@mexang10 @rohit188 @bitm4ster @PS-Bala @mclean25 @YuriYurievRadanov @nilanjansen @Rogeriohsjr @nithya-narashiman @servety @hassansultan @justcallmeM @BenediktBlana @janclarin @uday-kb @threegeese @IsaacLf @yiogurtina @kdw313 @Konglingpeng @anandsiddharth @sinumohan @aparnaittekot @lexingrensheng @Cook-R @Sandlimatharoo24 @AnkitChourasiyaTech @yury-fedorov @michniewicz @ulandj @junedkazi @shitiankexin @xiongqisong @weng0jun @syurchenkov @TenGbps @Abuhendi @Paroe2 @IngSimon @pir0n @hm001002009 @pierreduf @com2u @s34s0n @C0d3rsBay @aueb @mlewandowski0 @ozozozoz @duckpowermb @HighTemplar-wjiang
Hottie hangout pics with nude babes https://4.fo/q8SFZGT
GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179#discussioncomment-4532838
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
[GitHub] [incubator-kvrocks] git-hulk edited a comment on the discussion: Only saying 'closes #issue' in PR is not enough
Posted by GitBox <gi...@apache.org>.
GitHub user git-hulk edited a comment on the discussion: Only saying 'closes #issue' in PR is not enough
Yes, it's hard to require contributors to do that. As a committer, what we can do is ask for more information if the issue/PR is not clear enough, then the merger can help to summarize or rewrite the commit message first.
GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179#discussioncomment-4386339
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
[GitHub] [incubator-kvrocks] tisonkun edited a comment on the discussion: Only saying 'closes #issue' in PR is not enough
Posted by GitBox <gi...@apache.org>.
GitHub user tisonkun edited a comment on the discussion: Only saying 'closes #issue' in PR is not enough
@ShooterIT If you find a specific PR without sufficient information/description, you as a committer can send a request changes review.
For some trivial changes like fix a typo or finish a subtasks whose tracking issue is clear defined (migrating tests, fixing clang-clippy linter), it needs not redundant description.
The GitHub-provided PULL_REQUEST_TEMPLATE mechanism can always grow too cumbersome to follow. I don't see a good practice for it - finally, most contributors omit it. (If it can support form like issue template, the case may be better, but not today.)
GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179#discussioncomment-4386296
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org
[GitHub] [incubator-kvrocks] git-hulk added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
Posted by GitBox <gi...@apache.org>.
GitHub user git-hulk added a comment to the discussion: Only saying 'closes #issue' in PR is not enough
Yes, it's hard to require contributors to do that. As a committer, what we can do is ask for more information if the issue/PR is not clear enough, then the merger help to summarize or rewrite the commit message first.
GitHub link: https://github.com/apache/incubator-kvrocks/discussions/1179#discussioncomment-4386339
----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org