You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jason van Zyl (JIRA)" <ji...@codehaus.org> on 2007/02/27 16:51:15 UTC
[jira] Created: (MNG-2851) The artifact handlers must be loaded
upfront for all operations
The artifact handlers must be loaded upfront for all operations
---------------------------------------------------------------
Key: MNG-2851
URL: http://jira.codehaus.org/browse/MNG-2851
Project: Maven 2
Issue Type: Improvement
Affects Versions: 2.1.x
Reporter: Jason van Zyl
Fix For: 2.1-alpha-1
check the test I've added to MavenEmbedderTest. Without this loading
of project (without deps) the artifact handlers don't get taken into
account when loading the project.
the artifact handlers are added somewhere in lifecycle executor which
is not even touched on readProjectWithDependencies().
Milos
On 2/27/07, Jason van Zyl <ja...@maven.org> wrote:
Hey,
Just wondering about reading the project twice in read project with
dependencies. Why are you trying to find the artifact handlers once
and then reading the project again?
Just wondering if you copied this stuff from internal components why
it's not working. Is this for the case where you've added new ones
after the embedder has started?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-2851) The artifact handlers must be loaded
upfront for all operations
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl closed MNG-2851.
------------------------------
Resolution: Fixed
Milos has fixed this in the embedder.
> The artifact handlers must be loaded upfront for all operations
> ---------------------------------------------------------------
>
> Key: MNG-2851
> URL: http://jira.codehaus.org/browse/MNG-2851
> Project: Maven 2
> Issue Type: Improvement
> Components: Artifacts and Repositories
> Affects Versions: 2.1.x
> Reporter: Jason van Zyl
> Fix For: 2.1-alpha-1
>
>
> check the test I've added to MavenEmbedderTest. Without this loading
> of project (without deps) the artifact handlers don't get taken into
> account when loading the project.
> the artifact handlers are added somewhere in lifecycle executor which
> is not even touched on readProjectWithDependencies().
> Milos
> On 2/27/07, Jason van Zyl <ja...@maven.org> wrote:
> Hey,
> Just wondering about reading the project twice in read project with
> dependencies. Why are you trying to find the artifact handlers once
> and then reading the project again?
> Just wondering if you copied this stuff from internal components why
> it's not working. Is this for the case where you've added new ones
> after the embedder has started?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2851) The artifact handlers must be loaded
upfront for all operations
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-2851:
-------------------------------
Fix Version/s: 2.1-alpha-1
> The artifact handlers must be loaded upfront for all operations
> ---------------------------------------------------------------
>
> Key: MNG-2851
> URL: http://jira.codehaus.org/browse/MNG-2851
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.1.x
> Reporter: Jason van Zyl
> Fix For: 2.1-alpha-1
>
>
> check the test I've added to MavenEmbedderTest. Without this loading
> of project (without deps) the artifact handlers don't get taken into
> account when loading the project.
> the artifact handlers are added somewhere in lifecycle executor which
> is not even touched on readProjectWithDependencies().
> Milos
> On 2/27/07, Jason van Zyl <ja...@maven.org> wrote:
> Hey,
> Just wondering about reading the project twice in read project with
> dependencies. Why are you trying to find the artifact handlers once
> and then reading the project again?
> Just wondering if you copied this stuff from internal components why
> it's not working. Is this for the case where you've added new ones
> after the embedder has started?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2851) The artifact handlers must be loaded
upfront for all operations
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_106248 ]
Jason van Zyl commented on MNG-2851:
------------------------------------
Milos, this has effectively been done in the embedder for now which is fine with me. We can add tests and improve it as we go.
John, they are needed when not executing but using the readProjectWithDependencies in the embedder. It's how IDE integration loads/imports projects and updates the POM without executing a goal/phase.
> The artifact handlers must be loaded upfront for all operations
> ---------------------------------------------------------------
>
> Key: MNG-2851
> URL: http://jira.codehaus.org/browse/MNG-2851
> Project: Maven 2
> Issue Type: Improvement
> Components: Artifacts and Repositories
> Affects Versions: 2.1.x
> Reporter: Jason van Zyl
> Fix For: 2.1-alpha-1
>
>
> check the test I've added to MavenEmbedderTest. Without this loading
> of project (without deps) the artifact handlers don't get taken into
> account when loading the project.
> the artifact handlers are added somewhere in lifecycle executor which
> is not even touched on readProjectWithDependencies().
> Milos
> On 2/27/07, Jason van Zyl <ja...@maven.org> wrote:
> Hey,
> Just wondering about reading the project twice in read project with
> dependencies. Why are you trying to find the artifact handlers once
> and then reading the project again?
> Just wondering if you copied this stuff from internal components why
> it's not working. Is this for the case where you've added new ones
> after the embedder has started?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2851) The artifact handlers must be loaded
upfront for all operations
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88723 ]
John Casey commented on MNG-2851:
---------------------------------
Sorry, where exactly are these artifact handlers meant to be used? Currently, any artifact handlers that are specified in build extensions should be available to the project-build process when executing a normal build, but this pre-scanning has two drawbacks:
1. it doesn't currently apply to direct use of the project builder outside of a build...though it could be, using the DefaultBuildExtensionScanner in maven-core.
2. the pre-scanning process doesn't look in plugin declarations for extensions (yet). I left this to the lifecycle executor for now, until I've had a chance to really take a deeper look at what moving that might impact.
> The artifact handlers must be loaded upfront for all operations
> ---------------------------------------------------------------
>
> Key: MNG-2851
> URL: http://jira.codehaus.org/browse/MNG-2851
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.1.x
> Reporter: Jason van Zyl
> Fix For: 2.1-alpha-1
>
>
> check the test I've added to MavenEmbedderTest. Without this loading
> of project (without deps) the artifact handlers don't get taken into
> account when loading the project.
> the artifact handlers are added somewhere in lifecycle executor which
> is not even touched on readProjectWithDependencies().
> Milos
> On 2/27/07, Jason van Zyl <ja...@maven.org> wrote:
> Hey,
> Just wondering about reading the project twice in read project with
> dependencies. Why are you trying to find the artifact handlers once
> and then reading the project again?
> Just wondering if you copied this stuff from internal components why
> it's not working. Is this for the case where you've added new ones
> after the embedder has started?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2851) The artifact handlers must be loaded
upfront for all operations
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-2851:
------------------------------
Component/s: Artifacts and Repositories
> The artifact handlers must be loaded upfront for all operations
> ---------------------------------------------------------------
>
> Key: MNG-2851
> URL: http://jira.codehaus.org/browse/MNG-2851
> Project: Maven 2
> Issue Type: Improvement
> Components: Artifacts and Repositories
> Affects Versions: 2.1.x
> Reporter: Jason van Zyl
> Fix For: 2.1-alpha-1
>
>
> check the test I've added to MavenEmbedderTest. Without this loading
> of project (without deps) the artifact handlers don't get taken into
> account when loading the project.
> the artifact handlers are added somewhere in lifecycle executor which
> is not even touched on readProjectWithDependencies().
> Milos
> On 2/27/07, Jason van Zyl <ja...@maven.org> wrote:
> Hey,
> Just wondering about reading the project twice in read project with
> dependencies. Why are you trying to find the artifact handlers once
> and then reading the project again?
> Just wondering if you copied this stuff from internal components why
> it's not working. Is this for the case where you've added new ones
> after the embedder has started?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira