Re: cvs commit:jakarta-turbine-2/src/java/org/apache/turbine/services/dbMapBrokerSe rvice.java PoolBrokerService.java TurbineDB.javaTurbineMapBrokerService.java TurbinePoolBrokerService.java

[Jason van Zyl <jv...@apache.org>]

On 9/27/01 12:58 PM, "John McNally" <jm...@collab.net> wrote:

> Can you explain the need for these changes?  If you are specifying the
> database name then you are not using the default.

I'm just allowing one to explicity state what the default is.

Say you have a single database and you actually give it a name:

<database name="application">
...
</database>

Than all your peers will be generated with a map builder that specifies the
use of the "application" database map and pool but the TurbineMapBuilder is
hardcoded with TurbineDB.getDatabaseMap() which always returns the
"default". The security system will not work if you don't give it some hints
via specifying a the default map and pool name.

I just thought the behavior was inconsistent. If you specify a database name
and that's where your security data goes than I feel than the
TurbineMapBuilder should obey that choice. It didn't.

I think being more explicit is safer, and I just wanted an app to specify
the database name and have all of turbine work with that specified name. All
works as expected if the properties are not specified.


> Why is there a need
> for different names for "default"?


 
> Sorry, I am confused.
> 
> john mcnally
> 
> Jason van Zyl wrote:
>> 
>> On 9/27/01 1:22 AM, "jvanzyl@apache.org" <jv...@apache.org> wrote:
>> 
>>> jvanzyl     01/09/26 22:22:32
>>> 
>>> Modified:    src/java/org/apache/turbine/services/db
>>>                       MapBrokerService.java PoolBrokerService.java
>>>                       TurbineDB.java TurbineMapBrokerService.java
>>>                       TurbinePoolBrokerService.java
>>> Log:
>>> - allow the default map and pool to be specified. makes life much
>>>   easier for multiple db setups. making this work is more evidence of
>>>   the super nasty coupling between torque and db service.
>>> 
>> 
>> these changes are backward compatible, if the properties for the default map
>> or pool are not specified the standard behavior of using "default" is
>> employed.
>> 
>> --
>> 
>> jvz.
>> 
>> Jason van Zyl
>> 
>> http://tambora.zenplex.org
>> http://jakarta.apache.org/turbine
>> http://jakarta.apache.org/velocity
>> http://jakarta.apache.org/alexandria
>> http://jakarta.apache.org/commons
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org

-- 

jvz.

Jason van Zyl

http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons



---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org