You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2003/07/08 08:32:58 UTC
cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationServlet.java
remm 2003/07/07 23:32:53
Modified: webapps/admin/WEB-INF/classes/org/apache/webapp/admin
ApplicationServlet.java
Log:
- Feel free to veto, but I believe a well behaved application should not
fork a thread for something like doing its init stuff (even if it's faster).
Revision Changes Path
1.4 +7 -18 jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationServlet.java
Index: ApplicationServlet.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationServlet.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ApplicationServlet.java 17 Mar 2003 07:50:12 -0000 1.3
+++ ApplicationServlet.java 8 Jul 2003 06:32:52 -0000 1.4
@@ -82,7 +82,7 @@
* @version $Revision$ $Date$
*/
-public class ApplicationServlet extends ActionServlet implements Runnable {
+public class ApplicationServlet extends ActionServlet {
// ----------------------------------------------------- Manifest Constants
@@ -147,19 +147,8 @@
* @exception ServletException if an initialization error occurs.
*/
public void init() throws javax.servlet.ServletException {
- new Thread(this).start();
- }
-
- public void run() {
- try {
- // Perform normal superclass initialization
- super.init();
-
- // Perform initialization specific to this application
- initApplicationLocales();
- } catch( Exception ex ) {
- ex.printStackTrace();
- }
+ super.init();
+ initApplicationLocales();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationServlet.java
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <re...@apache.org>
To: <ja...@apache.org>
Sent: Monday, July 07, 2003 11:32 PM
Subject: cvs commit:
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admi
n ApplicationServlet.java
> remm 2003/07/07 23:32:53
>
> Modified: webapps/admin/WEB-INF/classes/org/apache/webapp/admin
> ApplicationServlet.java
> Log:
> - Feel free to veto, but I believe a well behaved application should not
> fork a thread for something like doing its init stuff (even if it's
faster).
>
I'll veto the veto unless the Thread is made a daemon.
+1 for the patch.