You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/09/29 18:12:52 UTC
Review Request 62696: Updated error messages in
`getMountNamespaceTarget()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62696/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.
Repository: mesos
Description
-------
Previously, `getMountNamespaceTarget()` ignored error messages
returned by `ns::getns()` and `os::children()`.
Diffs
-----
src/slave/containerizer/mesos/utils.cpp be8126da00b690e83ec379393e78457b5ff0acee
Diff: https://reviews.apache.org/r/62696/diff/1/
Testing
-------
make check (fedora)
Thanks,
Andrei Budnik
Re: Review Request 62696: Updated error messages in
`getMountNamespaceTarget()`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62696/#review186741
-----------------------------------------------------------
PASS: Mesos patch 62696 was successfully built and tested.
Reviews applied: `['62696']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62696
- Mesos Reviewbot Windows
On Sept. 29, 2017, 11:12 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62696/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 11:12 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, `getMountNamespaceTarget()` ignored error messages
> returned by `ns::getns()` and `os::children()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/utils.cpp be8126da00b690e83ec379393e78457b5ff0acee
>
>
> Diff: https://reviews.apache.org/r/62696/diff/1/
>
>
> Testing
> -------
>
> make check (fedora)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 62696: Updated error messages in
`getMountNamespaceTarget()`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62696/#review186905
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62696]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 2, 2017, 4:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62696/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 4:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, `getMountNamespaceTarget()` ignored error messages
> returned by `ns::getns()` and `os::children()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/utils.cpp be8126da00b690e83ec379393e78457b5ff0acee
>
>
> Diff: https://reviews.apache.org/r/62696/diff/2/
>
>
> Testing
> -------
>
> make check (fedora)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 62696: Updated error messages in
`getMountNamespaceTarget()`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62696/#review186943
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Oct. 2, 2017, 4:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62696/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 4:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, `getMountNamespaceTarget()` ignored error messages
> returned by `ns::getns()` and `os::children()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/utils.cpp be8126da00b690e83ec379393e78457b5ff0acee
>
>
> Diff: https://reviews.apache.org/r/62696/diff/2/
>
>
> Testing
> -------
>
> make check (fedora)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 62696: Updated error messages in
`getMountNamespaceTarget()`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62696/#review186902
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62696']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62696
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62696/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/0 (304 ms)
[ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1 (298 ms)
[ RUN ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2
[ OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 (313 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/0
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 (301 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/1
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 (350 ms)
[ RUN ] Endpoint/SlaveEndpointTest.NoAuthorizer/2
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (307 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (3232 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (135 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (151 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (347 ms total)
[----------] Global test environment tear-down
[==========] 714 tests from 72 test cases ran. (399200 ms total)
[ PASSED ] 713 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
1 FAILED TEST
YOU HAVE 161 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62696/logs/mesos-tests-stderr.log):
```
I1002 21:58:45.584635 26792 containerizer.cpp:648] Recovering containerizer
I1002 21:58:45.595697 30016 provisioner.cpp:416] Provisioner recovery complete
I1002 21:58:45.596633 32756 slave.cpp:6310] Finished recovery
I1002 21:58:45.619637 32756 http.cpp:1185] HTTP GET for /slave(270)/monitor/statistics.json from 10.3.1.7:60788
I1002 21:58:45.639307 32756 http.cpp:976] Authorizing principal 'test-principal' to GET the '/monitor/statistics.json' endpoint
I1002 21:58:45.660298 13520 slave.cpp:869] Agent terminating
I1002 21:58:45.812297 32280 containerizer.cpp:292] Using isolation { windows/cpu, filesystem/windows, environment_secret }
I1002 21:58:45.819296 32280 provisioner.cpp:255] Using default backend 'copy'
I1002 21:58:45.832296 32280 cluster.cpp:448] Creating default 'local' authorizer
I1002 21:58:45.851299 30156 slave.cpp:254] Mesos agent started on (271)@10.3.1.7:59843
I1002 21:58:45.851299 30156 slave.cpp:255] Flags at startup: --acls="" --appc_simple_discovery_uri_prefix="http://" --appc_store_dir="C:\Users\mesos\AppData\Local\Temp\2\mI5piA\store\appc" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticatee="crammd5" --authentication_backoff_factor="1secs" --authorizer="local" --container_disk_watch_interval="15secs" --containerizers="mesos" --credential="C:\Users\mesos\AppData\Local\Temp\2\mI5piA\credential" --default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io" --docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" --docker_stop_timeout="0ns" --docker_store_dir="C:\Users\mesos\AppData\Local\Temp\2\mI5piA\store\docker" --docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" --enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_reregistration_timeout="2secs" -
-executor_shutdown_grace_period="5secs" --fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\2\mI5piA\fetch" --fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks" --gc_disk_headroom="0.1" --hadoop_home="" --help="false" --hostname_lookup="true" --http_command_executor="false" --http_credentials="C:\Users\mesos\AppData\Local\Temp\2\mI5piA\http_credentials" --http_heartbeat_interval="30secs" --initialize_driver_logging="true" --isolation="windows/cpu" --launcher="windows" --launcher_dir="C:\mesos\src" --logbufsecs="0" --logging_level="INFO" --max_completed_executors_per_framework="150" --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns" --quiet="false" --recover="reconnect" --recovery_timeout="15mins" --registration_backoff_factor="10ms" --resources="cpus:2;gpus:0;mem:1024;disk:1024;ports:[31000-32000]" --runtime_dir="C:\Users\mesos\AppData\Local\Temp\2\mI5piA" --sandbox_directory="C:\mesos\sandbox" --strict="true" --version="
false" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\dS2YAt" --zk_session_timeout="10secs"
I1002 21:58:45.882302 30156 credentials.hpp:86] Loading credential for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\mI5piA\credential'
I1002 21:58:45.883298 30156 slave.cpp:287] Agent using credential for: test-principal
I1002 21:58:45.884299 30156 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\mI5piA\http_credentials'
I1002 21:58:45.902299 30156 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readonly'
I1002 21:58:45.903300 30156 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readwrite'
I1002 21:58:45.914300 30156 slave.cpp:585] Agent resources: [{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
I1002 21:58:45.918300 30156 slave.cpp:593] Agent attributes: [ ]
I1002 21:58:45.918300 30156 slave.cpp:602] Agent hostname: mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1002 21:58:45.918300 30888 status_update_manager.cpp:177] Pausing sending status updates
I1002 21:58:45.925300 26792 state.cpp:64] Recovering state from 'C:\Users\mesos\AppData\Local\Temp\2\dS2YAt\meta'
I1002 21:58:45.930306 30852 status_update_manager.cpp:203] Recovering status update manager
I1002 21:58:45.944303 32756 containerizer.cpp:648] Recovering containerizer
I1002 21:58:45.951301 26792 provisioner.cpp:416] Provisioner recovery complete
I1002 21:58:45.956303 30888 slave.cpp:6310] Finished recovery
I1002 21:58:45.980303 13520 http.cpp:1185] HTTP GET for /slave(271)/containers from 10.3.1.7:60789
I1002 21:58:45.981303 13520 http.cpp:976] Authorizing principal 'test-principal' to GET the '/containers' endpoint
I1002 21:58:46.000304 32280 slave.cpp:869] Agent terminating
I1002 21:58:46.850010 18848 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Oct. 2, 2017, 9:54 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62696/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 9:54 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, `getMountNamespaceTarget()` ignored error messages
> returned by `ns::getns()` and `os::children()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/utils.cpp be8126da00b690e83ec379393e78457b5ff0acee
>
>
> Diff: https://reviews.apache.org/r/62696/diff/2/
>
>
> Testing
> -------
>
> make check (fedora)
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 62696: Updated error messages in
`getMountNamespaceTarget()`.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62696/
-----------------------------------------------------------
(Updated Oct. 2, 2017, 4:54 p.m.)
Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.
Repository: mesos
Description
-------
Previously, `getMountNamespaceTarget()` ignored error messages
returned by `ns::getns()` and `os::children()`.
Diffs (updated)
-----
src/slave/containerizer/mesos/utils.cpp be8126da00b690e83ec379393e78457b5ff0acee
Diff: https://reviews.apache.org/r/62696/diff/2/
Changes: https://reviews.apache.org/r/62696/diff/1-2/
Testing
-------
make check (fedora)
Thanks,
Andrei Budnik
Re: Review Request 62696: Updated error messages in
`getMountNamespaceTarget()`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62696/#review186812
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62696]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 29, 2017, 6:12 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62696/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 6:12 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, `getMountNamespaceTarget()` ignored error messages
> returned by `ns::getns()` and `os::children()`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/utils.cpp be8126da00b690e83ec379393e78457b5ff0acee
>
>
> Diff: https://reviews.apache.org/r/62696/diff/1/
>
>
> Testing
> -------
>
> make check (fedora)
>
>
> Thanks,
>
> Andrei Budnik
>
>