You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/05/13 07:14:41 UTC
Review Request 59255: Some users hope that the pid file of the Ranger
Admin
can be unified management when they integrate Ranger into the big data
platform or business systems to uniform install and run Ranger.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1575
https://issues.apache.org/jira/browse/RANGER-1575
Repository: ranger
Description
-------
Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
We will explicitly document this change in the next release.
Diffs
-----
embeddedwebserver/scripts/ranger-admin-services.sh a81219b
Diff: https://reviews.apache.org/r/59255/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
This function is perfect if user independently use our ranger.
There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
We should meet this need by minor modifications without affecting the current function and logic.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
>
> Gautam Borad wrote:
> +1 for Colm's suggestions.
>
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
>
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So the value for RANGER_PID_DIR_PATH variable can not be changed after install Ranger Admin. The user can only change the pid name and can not change the path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run Ranger Admin service.
> for custom_env_script in `find ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
>
> Hi Colm, Do you have better opinion? Thanks!
>
> Qiang Zhang wrote:
> Hi Colm, I think that pengjianhua's modification logic is also very reasonable. In the case of meeting new needs, his logic is very well compatible with the existing logic and does not introduce new problems.
> About your opinion and his logic, do you think which is more appropriate to submit this issue? I tend to his logic after reading his explanation.
Is it possible to modify the logic of the "for custom_env_script" above so that it only sets e.g. RANGER_PID_DIR_PATH if there isn't a user (runtime) defined value for it already?
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On May 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated May 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
>
> Gautam Borad wrote:
> +1 for Colm's suggestions.
+1 for Colm's suggestions.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
>
> Gautam Borad wrote:
> +1 for Colm's suggestions.
>
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
>
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So the value for RANGER_PID_DIR_PATH variable can not be changed after install Ranger Admin. The user can only change the pid name and can not change the path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run Ranger Admin service.
> for custom_env_script in `find ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
>
> Hi Colm, Do you have better opinion? Thanks!
Hi Colm, I think that pengjianhua's modification logic is also very reasonable. In the case of meeting new needs, his logic is very well compatible with the existing logic and does not introduce new problems.
About your opinion and his logic, do you think which is more appropriate to submit this issue? I tend to his logic after reading his explanation.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Gautam Borad <gb...@gmail.com>.
> On May 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
+1 for Colm's suggestions.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On May 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated May 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
>
> Gautam Borad wrote:
> +1 for Colm's suggestions.
>
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
>
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So the value for RANGER_PID_DIR_PATH variable can not be changed after install Ranger Admin. The user can only change the pid name and can not change the path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run Ranger Admin service.
> for custom_env_script in `find ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
>
> Hi Colm, Do you have better opinion? Thanks!
>
> Qiang Zhang wrote:
> Hi Colm, I think that pengjianhua's modification logic is also very reasonable. In the case of meeting new needs, his logic is very well compatible with the existing logic and does not introduce new problems.
> About your opinion and his logic, do you think which is more appropriate to submit this issue? I tend to his logic after reading his explanation.
>
> Colm O hEigeartaigh wrote:
> Is it possible to modify the logic of the "for custom_env_script" above so that it only sets e.g. RANGER_PID_DIR_PATH if there isn't a user (runtime) defined value for it already?
>
> Qiang Zhang wrote:
> Ok. These methods are able to achieve this function. This issue can be finished based on your opinion.
I will rebuild the patch according your opinion.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On May 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated May 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
>
> Gautam Borad wrote:
> +1 for Colm's suggestions.
>
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
>
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So the value for RANGER_PID_DIR_PATH variable can not be changed after install Ranger Admin. The user can only change the pid name and can not change the path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run Ranger Admin service.
> for custom_env_script in `find ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
>
> Hi Colm, Do you have better opinion? Thanks!
>
> Qiang Zhang wrote:
> Hi Colm, I think that pengjianhua's modification logic is also very reasonable. In the case of meeting new needs, his logic is very well compatible with the existing logic and does not introduce new problems.
> About your opinion and his logic, do you think which is more appropriate to submit this issue? I tend to his logic after reading his explanation.
>
> Colm O hEigeartaigh wrote:
> Is it possible to modify the logic of the "for custom_env_script" above so that it only sets e.g. RANGER_PID_DIR_PATH if there isn't a user (runtime) defined value for it already?
>
> Qiang Zhang wrote:
> Ok. These methods are able to achieve this function. This issue can be finished based on your opinion.
>
> pengjianhua wrote:
> I will rebuild the patch according your opinion.
I updated the patch according to your review.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On 五月 23, 2017, 4:07 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 4:07 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
>
> Gautam Borad wrote:
> +1 for Colm's suggestions.
>
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So the value for RANGER_PID_DIR_PATH variable can not be changed after install Ranger Admin. The user can only change the pid name and can not change the path according to Colm's opinion.
1. The value for RANGER_PID_DIR_PATH was writed to ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when installing Ranger Admin.
2. Get the value for RANGER_PID_DIR_PATH through following code when run Ranger Admin service.
for custom_env_script in `find ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name "ranger-admin-env*"`; do
if [ -f $custom_env_script ]; then
. $custom_env_script
fi
done
Hi Colm, Do you have better opinion? Thanks!
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/59255/diff/1/?file=1717758#file1717758line71>
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
>
> pengjianhua wrote:
> This function is perfect if user independently use our ranger.
> There is defect for ranger when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger. These systems require services to support multiple instances, that is, the same service can been run multiple instances in the same node. These systems need to dynamically change the pid file path to avoid conflicts when they run service. They hope that ranger also has the ability to dynamically change the pid path at startup.
> We should meet this need by minor modifications without affecting the current function and logic.
>
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or something which would default to "rangeradmin.pid". So if you want to customise it you can change the path via RANGER_PID_DIR_PATH and the filename via RANGER_ADMIN_PID_NAME.
>
> Gautam Borad wrote:
> +1 for Colm's suggestions.
>
> Qiang Zhang wrote:
> +1 for Colm's suggestions.
>
> pengjianhua wrote:
> The RANGER_PID_DIR_PATH variable was set when installing Ranger Admin. So the value for RANGER_PID_DIR_PATH variable can not be changed after install Ranger Admin. The user can only change the pid name and can not change the path according to Colm's opinion.
> 1. The value for RANGER_PID_DIR_PATH was writed to ./ews/webapp/WEB-INF/classes/conf/ranger-admin-env-piddir.sh file when installing Ranger Admin.
> 2. Get the value for RANGER_PID_DIR_PATH through following code when run Ranger Admin service.
> for custom_env_script in `find ${XAPOLICYMGR_DIR}/ews/webapp/WEB-INF/classes/conf/ -name "ranger-admin-env*"`; do
> if [ -f $custom_env_script ]; then
> . $custom_env_script
> fi
> done
>
> Hi Colm, Do you have better opinion? Thanks!
>
> Qiang Zhang wrote:
> Hi Colm, I think that pengjianhua's modification logic is also very reasonable. In the case of meeting new needs, his logic is very well compatible with the existing logic and does not introduce new problems.
> About your opinion and his logic, do you think which is more appropriate to submit this issue? I tend to his logic after reading his explanation.
>
> Colm O hEigeartaigh wrote:
> Is it possible to modify the logic of the "for custom_env_script" above so that it only sets e.g. RANGER_PID_DIR_PATH if there isn't a user (runtime) defined value for it already?
Ok. These methods are able to achieve this function. This issue can be finished based on your opinion.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
-----------------------------------------------------------
embeddedwebserver/scripts/ranger-admin-services.sh
Lines 71 (patched)
<https://reviews.apache.org/r/59255/#comment248132>
Users can set RANGER_PID_DIR_PATH if they don't want to use default path. So what is the need for an additional variable?
- Velmurugan Periasamy
On May 13, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated May 13, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review175947
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 五月 23, 2017, 4:07 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 4:07 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review175914
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 23, 2017, 4:07 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 4:07 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
>
> We will explicitly document this change in the next release.
>
>
> Diffs
> -----
>
> embeddedwebserver/scripts/ranger-admin-services.sh a81219b
>
>
> Diff: https://reviews.apache.org/r/59255/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59255: Some users hope that the pid file of the
Ranger
Admin can be unified management when they integrate Ranger into the big
data platform or business systems to uniform install and run Ranger.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/
-----------------------------------------------------------
(Updated 五月 23, 2017, 4:07 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1575
https://issues.apache.org/jira/browse/RANGER-1575
Repository: ranger
Description
-------
Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and run Ranger.
We should support the need in the case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs.
We will explicitly document this change in the next release.
Diffs (updated)
-----
embeddedwebserver/scripts/ranger-admin-services.sh a81219b
Diff: https://reviews.apache.org/r/59255/diff/2/
Changes: https://reviews.apache.org/r/59255/diff/1-2/
Testing
-------
Thanks,
pengjianhua