You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "windro-xdd (via GitHub)" <gi...@apache.org> on 2026/04/14 20:11:00 UTC
[PR] fix(ui): avoid false unused plural keys in translation completeness checker [airflow]
windro-xdd opened a new pull request, #65259:
URL: https://github.com/apache/airflow/pull/65259
## Summary
- Fix `check-translation-completeness` so plural keys are expanded not only when EN contains `{{count}}`, but also when EN already has multiple plural forms for the same base (for example `_one` + `_other`).
- This avoids false "unused" reports for locale-specific plural forms in languages like Polish.
- Added focused tests for both the helper behavior and compare flow regression.
## Why
Issue #65229 reports that language-specific plural forms can be marked as unused even when plural routing is active.
## Tests
- `uv run ruff format dev/breeze/src/airflow_breeze/commands/ui_commands.py dev/breeze/tests/test_ui_commands.py`
- `uv run ruff check --fix dev/breeze/src/airflow_breeze/commands/ui_commands.py dev/breeze/tests/test_ui_commands.py`
- `uv run --project dev/breeze pytest dev/breeze/tests/test_ui_commands.py -xvs`
Closes #65229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): avoid false unused plural keys in translation completeness checker [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #65259:
URL: https://github.com/apache/airflow/pull/65259#issuecomment-4247211413
Pending CI passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): avoid false unused plural keys in translation completeness checker [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #65259:
URL: https://github.com/apache/airflow/pull/65259#issuecomment-4248018375
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): avoid false unused plural keys in translation completeness checker [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #65259:
URL: https://github.com/apache/airflow/pull/65259#issuecomment-4248026914
### Backport successfully created: v3-2-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/pull/65270"><img src="https://img.shields.io/badge/PR-65270-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): avoid false unused plural keys in translation completeness checker [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #65259:
URL: https://github.com/apache/airflow/pull/65259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org