[PR] fix(ui): open magnetic model pickers without shifting nearby controls [maka]

["M4n5ter (via GitHub)" <gi...@apache.org>]

M4n5ter opened a new pull request, #5257:
URL: https://github.com/apache/maka/pull/5257

   <details open>
   <summary>English</summary>
   
   ## Summary
   
   Opening a model picker replaced its button with a 132px wheel, pushing composer controls and settings rows out of place. The shared picker now keeps the button mounted and opens an anchored top-layer overlay. Center magnification, snap-to-select, keyboard navigation, and focus restoration remain available at every entry point.
   
   Compact WorkHub reserves space above its composer through the existing measured, bottom-anchored window sizing. This keeps the wheel inside the native window while the editor, send button, and conversation toggle stay at their original screen coordinates.
   
   Refs #5227.
   
   ## Verification
   
   - Desktop/UI builds and affected typechecks passed; repository lint and formatting checks passed.
   - 27 picker/recovery/WorkHub component tests and 10 Storybook-runner tests passed.
   - 48 targeted Storybook renders passed, including light/dark WorkHub, forced-colors settings, daily review, subagent settings, and provider configuration.
   - Restoring the old picker made the new geometry checks fail in settings and both WorkHub themes: the WorkHub editor moved from `y=798` to `y=698`. Restoring the overlay made those checks pass.
   - Full local Electron E2E suite: **38/38 passed**, without retries. The focused WorkHub native-window test also passed.
   - Electron budget remains 38 tests in 22 files. Centering and light/dark focus checks moved into the existing WorkHub story; native clipping, screen-position stability, and dragging within a frameless window remain in Electron. No Electron fixture launches were added or removed. Cross-window appearance propagation remains covered by WorkHub reconstruction.
   
   The complete Storybook catalog and full repository unit suite were not run.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex implemented the overlay and native-window layout changes, updated regression coverage, and ran local validation.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   
   </details>
   
   <details>
   <summary>中文</summary>
   
   ## Summary / 变更说明
   
   原来的模型选择器展开时，会用 132px 高的滚轮替换按钮，导致输入区和设置项跟着挪动。现在保留按钮占位，滚轮通过共享的顶层浮层展开。所有入口仍保留中央项放大、磁吸后自动选中、键盘切换和关闭后恢复焦点的能力。
   
   WorkHub 紧凑悬浮窗还需要处理原生窗口边界：浮层无法画到窗口外面。因此沿用现有的高度测量和底部定位，在输入区上方留出空间，让窗口向上增高。输入框、发送按钮和展开对话按钮的屏幕位置保持不变，滚轮也不会被裁切。
   
   关联 #5227。
   
   ## Verification / 验证
   
   - Desktop/UI 构建、相关类型检查，以及仓库 lint、格式检查通过。
   - 27 个选择器、恢复流程和 WorkHub 组件测试，以及 10 个 Storybook 运行器测试通过。
   - 48 个相关 Storybook 渲染场景通过，覆盖 WorkHub 明暗主题、设置页高对比度、每日回顾、子 Agent 和供应商配置。
   - 用旧选择器反跑新增的位置断言，设置页和 WorkHub 明暗主题均失败；WorkHub 输入区的纵坐标从 `798` 变成 `698`。恢复浮层实现后，断言全部通过。
   - 本地完整 Electron E2E：**38/38 通过**，无重试。单独运行的 WorkHub 窗口边界测试也通过。
   - Electron 仍为 22 个文件、38 个测试。选中项居中和明暗主题焦点检查移入现有 WorkHub story；窗口裁切、控件屏幕位置及无边框窗口中的拖动仍由 Electron 验证，没有增减原生窗口测试的启动次数。跨窗口外观同步仍由 WorkHub 重建测试覆盖。
   
   未运行完整 Storybook 目录和全仓库单元测试。
   
   ## AI use / AI 使用
   
   - [ ] 未使用生成式工具进行实质性工作
   - [x] 使用了生成式工具进行实质性工作
   
   工具及范围：Codex 完成浮层与原生窗口布局修改、补充回归验证，并执行本地检查。
   
   ## Checklist / 检查项
   
   - [x] 测试覆盖本次改动，恢复旧实现后会失败
   - [x] lint、格式、类型检查及相关测试在本地通过
   
   本 PR 是否改变行为？
   
   - [x] 是，已在变更说明中描述
   - [ ] 否
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] fix(ui): open magnetic model pickers without shifting nearby controls [maka]

["M4n5ter (via GitHub)" <gi...@apache.org>]

M4n5ter merged PR #5257:
URL: https://github.com/apache/maka/pull/5257


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org