You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/16 03:53:25 UTC

[GitHub] [incubator-superset] justinphamvn opened a new issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

justinphamvn opened a new issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298


   Pivot table not work correctly with **Sum Total**
   I have a Pivot Table with:
   
   Distributor Code / Sum of Quantity / Sum of Amount
   2000006 / 31,637 / 468,966,500
   2000013 / 28,826 / 238,210,000
    
   ### Expected results
   **Sum Total work correctly**
   Total Quantity: **60,463**
   Total Amount: **707,176,500**
   
   ### Actual results
   **Sum Total not work correctly** 
   Total Quantity: **31,637** (_It's only calculate with MAX instead SUM function_)
   Total Amount: **468,966,000** ( _Max and Auto Rounding !!!_ )
   
   #### Screenshots
   
   ![Superset_PivotTable_issues](https://user-images.githubusercontent.com/72958231/96210995-5842ff80-0f9d-11eb-9175-4c722abe9b66.png)
   
   ### Environment
   
   - superset version: 0.37.2
   - python version: 3.6


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] korridor commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
korridor commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-744381195


   I am also still having the same problem with version 0.38.0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-726243093


   Never mind, need more investigation


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] junlincc commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-709749495


   thanks for reporting @justinphamvn justinphamvn
   
   It looks like there are more issues around the pivot table besides sorting and icons...... 
   
   https://github.com/apache/incubator-superset/issues/11268
   https://github.com/apache/incubator-superset/issues/11250
   https://github.com/apache/incubator-superset/issues/10737 
   
   @villebro 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud closed issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
ktmud closed issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] magic-overflow commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
magic-overflow commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-739857892


   ![image](https://user-images.githubusercontent.com/7246515/101345420-941d8580-38b9-11eb-803f-3e1dcfbb27c8.png)
   Version 0.38.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-726218125


   <img src="https://user-images.githubusercontent.com/335541/98973043-16d44000-24c8-11eb-9c29-86892d2c6e3e.png" width="300">
   
   As you can see, the sum for `sum(metric2)` is incorrect. It ignores the last row `dim1 = c` where `sum(metric1)` is null.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] korridor edited a comment on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
korridor edited a comment on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-744381195


   I am also still having the same problem with version 0.38.0. @junlincc Can you please reference the pull request or commit that fixed that problem. Maybe I can look into that in more detail with that information.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] junlincc commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-710742452


   @justinphamvn this issue should have been fixed in master, can you double check? thanks !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-709715356


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] justinphamvn closed issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
justinphamvn closed issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-709848139


   @justinphamvn are you sure your columns are numeric? This is what I'm getting on current master (I didn't test on 0.37.2, but I suspect the behavior to be the same):
   ![image](https://user-images.githubusercontent.com/33317356/96221842-e74b1a00-0f93-11eb-9b1a-e967359636cc.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud removed a comment on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
ktmud removed a comment on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-726218125






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] justinphamvn commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
justinphamvn commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-709867878


   > @justinphamvn are you sure your columns are numeric? This is what I'm getting on current master (I didn't test on 0.37.2, but I suspect the behavior to be the same):
   > ![image](https://user-images.githubusercontent.com/33317356/96221842-e74b1a00-0f93-11eb-9b1a-e967359636cc.png)
   
   Hi @villebro 
   Yes, it is definitely a numeric type because before upgrade to 0.37.2 It work very well on 0.37.0 version
   
   ![Superset_PivotTable](https://user-images.githubusercontent.com/72958231/96224057-25a70000-0fb9-11eb-80d4-1a48031b0c37.png)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on issue #11298: [Bug 0.37.2 Pivot Table] Pivot table not work correctly with Sum Total - Version 0.37.2

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #11298:
URL: https://github.com/apache/incubator-superset/issues/11298#issuecomment-726217252


   This bug still exists:
   
   Here's a test query to reproduce:
   
   ```sql
   SELECT 1 as metric1, 2 as metric2, 'a' as dim1, 'a' as dim2
   UNION SELECT 2, 0, 'b', 'a'
   UNION SELECT 5, 2, 'a', 'a'
   UNION SELECT null, 5, 'c', 'b'
   ```
   
   Create a virtual datasource using this query, use both `metric1` and `metric2` in metrics, and select `dim1` in "Group by"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org