You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/12/04 16:06:39 UTC
[GitHub] brodybits commented on issue #568: Move the PLUGIN GRADLE
EXTENSIONS comments
brodybits commented on issue #568: Move the PLUGIN GRADLE EXTENSIONS comments
URL: https://github.com/apache/cordova-android/pull/568#issuecomment-444155124
Thanks @tombell for the proposal. I don't really understand how moving the comments would help solve a problem with extensions that are injected.
From what I see I think I would actually favor keeping the "EXTENSIONS START" comment where it is and moving the "EXTENSIONS END" as you proposed.
As a general comment I still do not have a super clear understanding of the structure and flow of the cordova-android Gradle files. Comments with a better explanation or maybe a better cleanup someday would be nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org