You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/13 21:38:49 UTC

[GitHub] [rocketmq-site] martin-g opened a new pull request #82: Improve the "How to contribute" docs

martin-g opened a new pull request #82:
URL: https://github.com/apache/rocketmq-site/pull/82


   * improve wording
   * fix typos
   * add links where appropriate
   * mention that Pull Requests are automatically tested at Travis CI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-site] martin-g commented on pull request #82: Improve the "How to contribute" docs

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #82:
URL: https://github.com/apache/rocketmq-site/pull/82#issuecomment-769830888


   Ping!
   @RongtongJin @vongosling


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-site] martin-g commented on a change in pull request #82: Improve the "How to contribute" docs

Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #82:
URL: https://github.com/apache/rocketmq-site/pull/82#discussion_r556857530



##########
File path: Gemfile
##########
@@ -1,2 +1,3 @@
 source "https://rubygems.org"
 gemspec
+gem "kramdown-parser-gfm"

Review comment:
       Without this I wasn't able to start Jekyll locally.
   I am not Jekyll/Ruby expert so please advice me if there is a different way to do it!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-site] martin-g commented on pull request #82: Improve the "How to contribute" docs

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #82:
URL: https://github.com/apache/rocketmq-site/pull/82#issuecomment-763548073


   Any comments on the proposed changes ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org