You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Slawomir Jaranowski (Jira)" <ji...@apache.org> on 2022/10/04 20:31:00 UTC
[jira] [Commented] (MWRAPPER-57) Make sure that Maven Wrapper created with distribution type set to script won't fail on Unix machines
[ https://issues.apache.org/jira/browse/MWRAPPER-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17612792#comment-17612792 ]
Slawomir Jaranowski commented on MWRAPPER-57:
---------------------------------------------
Another proposition MWRAPPER-59 - inline {{MavenWrapperDownloader.java}} into {{mvnw}} script.
> Make sure that Maven Wrapper created with distribution type set to script won't fail on Unix machines
> -----------------------------------------------------------------------------------------------------
>
> Key: MWRAPPER-57
> URL: https://issues.apache.org/jira/browse/MWRAPPER-57
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Plugin
> Reporter: Adam Gabrys
> Priority: Minor
>
> When the Maven {{wrapper:wrapper}} goal is executed with the {{-Dtype=script}} parameter the {{maven-wrapper.jar}} and {{MavenWrapperDownloader.java}} files are not created. The problem is that the {{mvnw.cmd}} script guarantees that the Maven distribution will be downloaded. However, the {{mvnw}} script fails when the {{curl}} and {{wget}} binaries are not installed. It may cause potential issues like "works on my PC, but fails on the {{CI}} system". The documentation doesn't Inform the users about that fact.
> I see a few possibilities to handle it:
> # remove the {{script}} option, then the people use {{bin}} or {{source}}. The {{source}} option generates the required {{MavenWrapperDownloader.java}} file
> # extend the {{script}} documentation with a warning that it may fail
> # generate different scripts depending on the chosen option - when {{script}} is not
--
This message was sent by Atlassian Jira
(v8.20.10#820010)