You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/08/20 09:30:05 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42573: [SPARK-44882][PYTHON][CONNECT] Remove function uuid/random/chr from PySpark
zhengruifeng opened a new pull request, #42573:
URL: https://github.com/apache/spark/pull/42573
### What changes were proposed in this pull request?
Remove function uuid/random/chr from PySpark
### Why are the changes needed?
`uuid` and `random` are also the names of [built-in modules](https://docs.python.org/3/library/index.html),
`chr` is the name of a [built-in function](https://docs.python.org/3/library/functions.html)
This PR is to avoid namespace conflict which may break existing workloads, e.g.
```
import uuid
from pyspark.sql.functions import *
print(uuid.uuid4())
```
The three functions are controversial and needs further discussion, we can add them back in the future.
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
updated CI
### Was this patch authored or co-authored using generative AI tooling?
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42573: [SPARK-44882][PYTHON][CONNECT] Remove function uuid/random/chr from PySpark
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42573:
URL: https://github.com/apache/spark/pull/42573#issuecomment-1685429574
cc @gatorsmile @HyukjinKwon @ueshin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42573: [SPARK-44882][PYTHON][CONNECT] Remove function uuid/random/chr from PySpark
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42573:
URL: https://github.com/apache/spark/pull/42573#issuecomment-1685438277
Merged to master and branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42573: [SPARK-44882][PYTHON][CONNECT] Remove function uuid/random/chr from PySpark
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42573: [SPARK-44882][PYTHON][CONNECT] Remove function uuid/random/chr from PySpark
URL: https://github.com/apache/spark/pull/42573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org