You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2024/09/04 22:01:00 UTC
[jira] [Commented] (IMPALA-13344) Impala rewrites may be incomplete
[ https://issues.apache.org/jira/browse/IMPALA-13344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879380#comment-17879380 ]
ASF subversion and git services commented on IMPALA-13344:
----------------------------------------------------------
Commit 7741edcf8bd6b815a0645c58c41f77fdf5470605 in impala's branch refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7741edcf8 ]
IMPALA-13344: Analyze new rewrite exprs
Ensures all new expressions created during ExprRewriteRule evaluation
are analyzed so later rules will evaluate them. Centralize analyzing and
logging new expressions created by rewrite rules.
Updates tests:
- one IMPALA-8030 test is fixed because it now applies
ExtractCommonConjunctRule after NormalizeBinaryPredicatesRule.
- several TPCDS tests have slight changes in how constant arithmetic
expression results are stored; FoldConstantsRule retains the original
type of the ArithmeticExpr, which may have a larger type (such as
SMALLINT instead of TINYINT) than the resulting NumericLiteral needs.
Change-Id: I6be731c2ea79c96e51d199c822e2cb34e5bb3028
Reviewed-on: http://gerrit.cloudera.org:8080/21679
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
> Impala rewrites may be incomplete
> ---------------------------------
>
> Key: IMPALA-13344
> URL: https://issues.apache.org/jira/browse/IMPALA-13344
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 4.0.0
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Major
> Fix For: Impala 4.5.0
>
>
> Impala's ExprRewriteRules may not be completely applied for complex expressions. Some implementations of ExprRewriteRule don't analyze new Expr they produce, which can lead to other rewrite rules ignoring those Expr. reAnalyze covers some of this by doing a 2nd analysis phase, but that only works for two layers.
> We should analyze any new Expr produced by an ExprRewriteRule.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org