You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/12 18:13:06 UTC
[GitHub] [arrow] paleolimbot opened a new issue, #33637: R package has a note about suppressed diagnostics on CRAN
paleolimbot opened a new issue, #33637:
URL: https://github.com/apache/arrow/issues/33637
### Describe the bug, including details regarding any error messages, version, and platform.
The NOTE from CRAN:
```
Version: 10.0.1
Check: compilation flags used
Result: WARN
Compilation used the following non-portable flag(s):
‘-Wall;-Wextra;-Wno-unknown-pragmas;-fvisibility=hidden;-Wstrict-prototypes;-ftls-model=local-dynamic’
‘-Wno-noexcept-type’ ‘-msse4.2’
including flag(s) suppressing warnings
```
https://cran.r-project.org/web/checks/check_results_arrow.html
This is odd because usually we suppress that output on CRAN. CRAN *may* be doing some extra environment variable stuff to make these message print out. We may need to revisit the code where we turn off the compiler output to make sure they are suppressed (or we may have to negotiate with CRAN regarding compiler warnings).
### Component(s)
R
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #33637: R package has a note about suppressed diagnostics on CRAN
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33637:
URL: https://github.com/apache/arrow/issues/33637#issuecomment-1384144651
I believe what happened is that CRAN set `ARROW_R_DEV=true` on one or more of its check machines, which means the verbose install logs got printed when building the vendored arrow. That may have been in good faith - to display as many warnings/errors as possible when running checks like gcc13 that are difficult/impossible to replicate otherwise - or it may be that they are planning to force the arrow package in line with the CRAN policy.
I think we should submit without changing anything and hope that it was the former...if CRAN has decided to enforce all of its policies on the arrow package, any attempt to actively circumvent that would be seen poorly (and probably wouldn't work anyway since they'd be manually inspecting changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on issue #33637: [R] R package has a note about suppressed diagnostics on CRAN
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #33637:
URL: https://github.com/apache/arrow/issues/33637#issuecomment-1568653906
I'm closing this as this doesn't seem to have caused us any problems with releases, but feel free to re-open if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on issue #33637: [R] R package has a note about suppressed diagnostics on CRAN
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on issue #33637:
URL: https://github.com/apache/arrow/issues/33637#issuecomment-1412239227
It's a silly policy for us because we use cmake to detect which compiler flags are valid to use on the current system. Hardcoding them would be dangerous, but that's not what we do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [R] R package has a note about suppressed diagnostics on CRAN [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed issue #33637: [R] R package has a note about suppressed diagnostics on CRAN
URL: https://github.com/apache/arrow/issues/33637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on issue #33637: [R] R package has a note about suppressed diagnostics on CRAN
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on issue #33637:
URL: https://github.com/apache/arrow/issues/33637#issuecomment-1568712055
I don't see it on the current checks page, FWIW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on issue #33637: R package has a note about suppressed diagnostics on CRAN
Posted by GitBox <gi...@apache.org>.
thisisnic commented on issue #33637:
URL: https://github.com/apache/arrow/issues/33637#issuecomment-1383887932
How/where do we suppress this? Given this has only come up in 10.0.1 where we were experimenting with the new release checklist, it'd be good to rule out if there's a step missing, was missed, or something different in my setup compared to Neal's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org