You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2010/03/31 01:31:57 UTC
[NET] 2.0 Change to Threadable#thread API
Clirr reports:
Parameter 1 of 'public org.apache.commons.net.nntp.Threadable
thread(org.apache.commons.net.nntp.Threadable[])' has changed its type
to java.util.List
It looks like this may have been an accidental change; it was
committed as part of r761877 whose log message is:
* Improve handling of invalid messages
* Add TODO for converting recursive flush() to iterative version
AFAICT, the change to Threadable does not fit with the rest of the commit.
I think the change should either be reverted, or the old API should be
reinstated and deprecated, for example using:
public Threadable thread(Threadable[] messages) {
return thread(Arrays.asList(messages));
}
I agree that using a List is better, but the API should not be changed
in a minor release.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [NET] 2.0 Change to Threadable#thread API
Posted by sebb <se...@gmail.com>.
On 31/03/2010, sebb <se...@gmail.com> wrote:
> Clirr reports:
>
> Parameter 1 of 'public org.apache.commons.net.nntp.Threadable
> thread(org.apache.commons.net.nntp.Threadable[])' has changed its type
> to java.util.List
>
> It looks like this may have been an accidental change; it was
> committed as part of r761877 whose log message is:
>
> * Improve handling of invalid messages
> * Add TODO for converting recursive flush() to iterative version
>
> AFAICT, the change to Threadable does not fit with the rest of the commit.
>
> I think the change should either be reverted, or the old API should be
> reinstated and deprecated, for example using:
>
> public Threadable thread(Threadable[] messages) {
> return thread(Arrays.asList(messages));
> }
>
>
> I agree that using a List is better, but the API should not be changed
> in a minor release.
>
Since there's been no response, I'll fix this by reinstating the
original method.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org