You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (Created) (JIRA)" <ji...@apache.org> on 2011/12/07 23:22:40 UTC
[jira] [Created] (THRIFT-1454) Better handling of write on a closed
TSocket
Better handling of write on a closed TSocket
---------------------------------------------
Key: THRIFT-1454
URL: https://issues.apache.org/jira/browse/THRIFT-1454
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
Attachments: 0005-Better-handling-of-write-on-a-closed-TSocket.patch
>From 9d33027d86ea95fc89567560a2cfd1c933bd5aaa Mon Sep 17 00:00:00 2001
From: Nathan Schrenk <ns...@fb.com>
Date: Fri, 23 Jul 2010 23:25:09 +0000
Subject: [PATCH 5/5] Better handling of write on a closed TSocket
Summary:
TSocket.send() was expecting a send() on the underlying socket
to fail by returning zero, but the actual behavior is to raise
an exception.
Test Plan:
I'll come up with a way to test this if the code change looks good to
the reviewers.
DiffCamp Revision: 135046
Reviewed By: dreiss
Commenters: simpkins
CC: python-diffs@lists, dreiss, kholst, simpkins, nschrenk, thrift-team@lists
Tasks:
closed socket
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1454) Better handling of write on a
closed TSocket
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164942#comment-13164942 ]
Hudson commented on THRIFT-1454:
--------------------------------
Integrated in Thrift #351 (See [https://builds.apache.org/job/Thrift/351/])
Thrift-1454:Better handling of write on a closed TSocket
Client: cpp
Patch: Dave Watson
TSocket.send() was expecting a send() on the underlying socket
to fail by returning zero, but the actual behavior is to raise
an exception.
> Better handling of write on a closed TSocket
> ---------------------------------------------
>
> Key: THRIFT-1454
> URL: https://issues.apache.org/jira/browse/THRIFT-1454
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Priority: Minor
> Attachments: 0005-Better-handling-of-write-on-a-closed-TSocket.patch
>
>
> From 9d33027d86ea95fc89567560a2cfd1c933bd5aaa Mon Sep 17 00:00:00 2001
> From: Nathan Schrenk <ns...@fb.com>
> Date: Fri, 23 Jul 2010 23:25:09 +0000
> Subject: [PATCH 5/5] Better handling of write on a closed TSocket
> Summary:
> TSocket.send() was expecting a send() on the underlying socket
> to fail by returning zero, but the actual behavior is to raise
> an exception.
> Test Plan:
> I'll come up with a way to test this if the code change looks good to
> the reviewers.
> DiffCamp Revision: 135046
> Reviewed By: dreiss
> Commenters: simpkins
> CC: python-diffs@lists, dreiss, kholst, simpkins, nschrenk, thrift-team@lists
> Tasks:
> closed socket
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1454) Better handling of write on a closed
TSocket
Posted by "Dave Watson (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Watson updated THRIFT-1454:
--------------------------------
Attachment: 0005-Better-handling-of-write-on-a-closed-TSocket.patch
> Better handling of write on a closed TSocket
> ---------------------------------------------
>
> Key: THRIFT-1454
> URL: https://issues.apache.org/jira/browse/THRIFT-1454
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Priority: Minor
> Attachments: 0005-Better-handling-of-write-on-a-closed-TSocket.patch
>
>
> From 9d33027d86ea95fc89567560a2cfd1c933bd5aaa Mon Sep 17 00:00:00 2001
> From: Nathan Schrenk <ns...@fb.com>
> Date: Fri, 23 Jul 2010 23:25:09 +0000
> Subject: [PATCH 5/5] Better handling of write on a closed TSocket
> Summary:
> TSocket.send() was expecting a send() on the underlying socket
> to fail by returning zero, but the actual behavior is to raise
> an exception.
> Test Plan:
> I'll come up with a way to test this if the code change looks good to
> the reviewers.
> DiffCamp Revision: 135046
> Reviewed By: dreiss
> Commenters: simpkins
> CC: python-diffs@lists, dreiss, kholst, simpkins, nschrenk, thrift-team@lists
> Tasks:
> closed socket
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1454) Better handling of write on a
closed TSocket
Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1454.
---------------------------------
Resolution: Fixed
Assignee: Dave Watson
> Better handling of write on a closed TSocket
> ---------------------------------------------
>
> Key: THRIFT-1454
> URL: https://issues.apache.org/jira/browse/THRIFT-1454
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Attachments: 0005-Better-handling-of-write-on-a-closed-TSocket.patch
>
>
> From 9d33027d86ea95fc89567560a2cfd1c933bd5aaa Mon Sep 17 00:00:00 2001
> From: Nathan Schrenk <ns...@fb.com>
> Date: Fri, 23 Jul 2010 23:25:09 +0000
> Subject: [PATCH 5/5] Better handling of write on a closed TSocket
> Summary:
> TSocket.send() was expecting a send() on the underlying socket
> to fail by returning zero, but the actual behavior is to raise
> an exception.
> Test Plan:
> I'll come up with a way to test this if the code change looks good to
> the reviewers.
> DiffCamp Revision: 135046
> Reviewed By: dreiss
> Commenters: simpkins
> CC: python-diffs@lists, dreiss, kholst, simpkins, nschrenk, thrift-team@lists
> Tasks:
> closed socket
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira