You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/09 06:51:27 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #17565: [improve][ci] Skip MacOS build for cpp-only changes
nicoloboschi opened a new pull request, #17565:
URL: https://github.com/apache/pulsar/pull/17565
Fixes #17558
### Motivation
There's no need to trigger the build on MacOS for cpp-only changes.
### Modifications
- Skipped the MacOs build in case of cpp-only change
- Improved the name of non required-checks to a friendly name.
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17565: [improve][ci] Skip MacOS build for cpp-only changes
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17565:
URL: https://github.com/apache/pulsar/pull/17565#discussion_r968046161
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -829,6 +798,39 @@ jobs:
- name: Delete docker image from GitHub Actions Artifacts
run: |
gh-actions-artifact-client.js delete pulsar-test-latest-version-image.zst
+
+ macos-build:
+ name: Build Pulsar on MacOS
+ runs-on: macos-11
+ timeout-minutes: 120
+ needs: ['changed_files_job', 'pulsar-test-latest-version-image']
Review Comment:
I think this shouldn't run before integration tests have run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #17565: [improve][ci] Skip MacOS build for cpp-only changes
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17565:
URL: https://github.com/apache/pulsar/pull/17565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #17565: [improve][ci] Skip MacOS build for cpp-only changes
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #17565:
URL: https://github.com/apache/pulsar/pull/17565#discussion_r968045236
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -127,11 +127,11 @@ jobs:
action: wait
macos-build:
- name:
+ name: Build Pulsar on MacOS
runs-on: macos-latest
timeout-minutes: 120
needs: [ 'changed_files_job', 'build-and-license-check' ]
Review Comment:
Right. Moved at the same "step" of `system-tests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17565: [improve][ci] Skip MacOS build for cpp-only changes
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17565:
URL: https://github.com/apache/pulsar/pull/17565#discussion_r967978549
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -127,11 +127,11 @@ jobs:
action: wait
macos-build:
- name:
+ name: Build Pulsar on MacOS
runs-on: macos-latest
timeout-minutes: 120
needs: [ 'changed_files_job', 'build-and-license-check' ]
Review Comment:
This should be moved to late stages of the pipeline so that it happens after integration tests. The reason for this is that there will be less re-runs at that stage. Our current assumption of the CI queuing problem is that when a workflow gets re-run, all previously executed jobs get counted in the usage reporting as if they were run again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org