[jira] [Commented] (PARQUET-1398) Separate iv_prefix for GCM and CTR modes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619678#comment-16619678 ] 

ASF GitHub Bot commented on PARQUET-1398:
-----------------------------------------

wesm closed pull request #496: PARQUET-1398: move iv_prefix to Algorithms
URL: https://github.com/apache/parquet-cpp/pull/496
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/parquet/parquet.thrift b/src/parquet/parquet.thrift
index aec8e542..f27609bd 100644
--- a/src/parquet/parquet.thrift
+++ b/src/parquet/parquet.thrift
@@ -891,11 +891,21 @@ struct FileMetaData {
 struct AesGcmV1 {
   /** Retrieval metadata of AAD used for encryption of pages and structures **/
   1: optional binary aad_metadata
+
+  /** If file IVs are comprised of a fixed part, and variable parts
+   *  (e.g. counter), keep the fixed part here **/
+  2: optional binary iv_prefix
 }
 
 struct AesGcmCtrV1 {
   /** Retrieval metadata of AAD used for encryption of structures **/
   1: optional binary aad_metadata
+
+  /** If file IVs are comprised of a fixed part, and variable parts
+   *  (e.g. counter), keep the fixed part here **/
+  2: optional binary gcm_iv_prefix
+
+  3: optional binary ctr_iv_prefix
 }
 
 union EncryptionAlgorithm {
@@ -915,10 +925,5 @@ struct FileCryptoMetaData {
 
   /** Offset of Parquet footer (encrypted, or plaintext) **/
   4: required i64 footer_offset
-  
-  /** If file IVs are comprised of a fixed part,
-   *  and variable parts (random or counter), keep the fixed
-   *  part here **/
-  5: optional binary iv_prefix
 }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Separate iv_prefix for GCM and CTR modes
> ----------------------------------------
>
>                 Key: PARQUET-1398
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1398
>             Project: Parquet
>          Issue Type: Sub-task
>          Components: parquet-cpp, parquet-format
>            Reporter: Gidon Gershinsky
>            Assignee: Gidon Gershinsky
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: format-2.6.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There is an ambiguity in what the iv_prefix applies to - GCM or CTR or both. This parameter will be moved it to the Algorithms structures (from the FileCryptoMetaData structure).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)