[GitHub] xtinec commented on a change in pull request #6781: Merge default feature flags and user defined feature flags

[GitBox <gi...@apache.org>]

xtinec commented on a change in pull request #6781: Merge default feature flags and user defined feature flags
URL: https://github.com/apache/incubator-superset/pull/6781#discussion_r252542028
 
 

 ##########
 File path: superset/utils/feature_flags.py
 ##########
 @@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=C,R,W
+from superset import feature_flags
 
 Review comment:
   Interesting question. I originally ran into a circular import issue by placing the utility function in `utils/core.py`. The second place I settled on was in `superset/__init__.py` itself as feature flags are tied to the app itself. I eventually moved it out into its own file to make testing easier but it is not strictly necessary for the `patch.dict` I was doing in tests.
   
   I don't think we'll run into circular imports even if we import `is_feature_enabled` from `superset/models/core.py`, which imports from `superset`, because `superset` specifically imports `utils.core`, not all of `utils`.
   
   How do you feel about placing this utility function in its own file VS in `superset/__init__.py`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org