You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/22 19:57:38 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1477: Fix SortExec discards field metadata on the output schema

alamb commented on a change in pull request #1477:
URL: https://github.com/apache/arrow-datafusion/pull/1477#discussion_r774136970



##########
File path: datafusion/src/physical_plan/sort.rs
##########
@@ -201,15 +201,6 @@ fn sort_batch(
         None,
     )?;
 
-    let schema = Arc::new(Schema::new(

Review comment:
       the fix is to delete this code, the rest of the file is a test

##########
File path: datafusion/src/physical_plan/sort.rs
##########
@@ -201,15 +201,6 @@ fn sort_batch(
         None,
     )?;
 
-    let schema = Arc::new(Schema::new(

Review comment:
       the fix is to delete this code, the rest of the PR is a test




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org