You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "0AyanamiRei (via GitHub)" <gi...@apache.org> on 2025/11/07 13:32:49 UTC
[PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
0AyanamiRei opened a new pull request, #57825:
URL: https://github.com/apache/doris/pull/57825
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
in BE, we check the strict mode by env variable query_option enable_insert_strict
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "0AyanamiRei (via GitHub)" <gi...@apache.org>.
0AyanamiRei commented on PR #57825:
URL: https://github.com/apache/doris/pull/57825#issuecomment-3502595981
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "liaoxin01 (via GitHub)" <gi...@apache.org>.
liaoxin01 merged PR #57825:
URL: https://github.com/apache/doris/pull/57825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57825:
URL: https://github.com/apache/doris/pull/57825#issuecomment-3502855457
<details>
<summary>TPC-DS: <b>Total hot run time: 187548 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c781490fbd59503a1afa918f8f26cd4828d5907, data reload: false
query1 1058 402 402 402
query2 6564 1720 1700 1700
query3 6754 226 218 218
query4 26234 23301 23275 23275
query5 4413 624 470 470
query6 351 247 248 247
query7 4646 499 299 299
query8 314 255 250 250
query9 8708 2584 2588 2584
query10 503 347 294 294
query11 15611 15061 15392 15061
query12 182 122 118 118
query13 1705 562 447 447
query14 11059 9173 9125 9125
query15 222 188 166 166
query16 7581 644 493 493
query17 1220 742 617 617
query18 2004 410 319 319
query19 202 194 170 170
query20 131 126 120 120
query21 218 145 114 114
query22 3965 4000 3915 3915
query23 33828 33195 32992 32992
query24 8484 2454 2391 2391
query25 582 513 441 441
query26 1235 266 155 155
query27 2770 511 346 346
query28 4371 2213 2179 2179
query29 786 603 484 484
query30 307 225 190 190
query31 908 818 732 732
query32 84 75 80 75
query33 595 373 335 335
query34 790 831 521 521
query35 805 829 742 742
query36 950 987 896 896
query37 118 114 89 89
query38 3516 3533 3458 3458
query39 1518 1424 1420 1420
query40 224 162 119 119
query41 68 62 60 60
query42 131 118 122 118
query43 486 504 467 467
query44 1214 745 732 732
query45 189 184 170 170
query46 876 992 623 623
query47 1745 1798 1700 1700
query48 398 421 329 329
query49 764 516 442 442
query50 645 684 412 412
query51 3883 3891 3918 3891
query52 114 111 104 104
query53 232 271 201 201
query54 309 287 274 274
query55 89 86 86 86
query56 346 347 315 315
query57 1168 1202 1102 1102
query58 283 276 270 270
query59 2516 2731 2529 2529
query60 350 346 319 319
query61 170 153 160 153
query62 789 745 662 662
query63 227 205 189 189
query64 4522 1152 943 943
query65 4014 3913 3944 3913
query66 1130 449 338 338
query67 15108 15021 15029 15021
query68 5189 937 627 627
query69 509 332 301 301
query70 1350 1241 1279 1241
query71 442 342 337 337
query72 6176 4822 4786 4786
query73 649 565 357 357
query74 9106 9260 8804 8804
query75 3301 3337 2798 2798
query76 3341 1144 724 724
query77 504 406 300 300
query78 9494 9603 8954 8954
query79 2092 836 598 598
query80 694 598 504 504
query81 500 268 226 226
query82 322 159 132 132
query83 285 267 250 250
query84 256 105 97 97
query85 877 478 436 436
query86 374 318 316 316
query87 3729 3773 3550 3550
query88 3019 2252 2245 2245
query89 372 320 289 289
query90 1991 239 220 220
query91 168 174 135 135
query92 80 69 65 65
query93 2509 993 639 639
query94 708 448 336 336
query95 400 314 316 314
query96 487 582 283 283
query97 2872 2975 2852 2852
query98 237 214 202 202
query99 1302 1404 1298 1298
Total cold run time: 270617 ms
Total hot run time: 187548 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57825:
URL: https://github.com/apache/doris/pull/57825#issuecomment-3503950928
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57825:
URL: https://github.com/apache/doris/pull/57825#issuecomment-3502596036
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57825:
URL: https://github.com/apache/doris/pull/57825#issuecomment-3502790823
<details>
<summary>TPC-H: <b>Total hot run time: 34250 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c781490fbd59503a1afa918f8f26cd4828d5907, data reload: false
------ Round 1 ----------------------------------
q1 17596 5229 5067 5067
q2 2019 316 207 207
q3 10278 1271 719 719
q4 10226 894 363 363
q5 7477 2454 2257 2257
q6 181 173 139 139
q7 917 760 652 652
q8 9356 1315 1174 1174
q9 7107 5315 5271 5271
q10 6892 2225 1764 1764
q11 484 305 300 300
q12 337 363 236 236
q13 17770 3638 3043 3043
q14 229 224 205 205
q15 588 513 500 500
q16 1027 981 932 932
q17 582 889 383 383
q18 7437 7075 6990 6990
q19 1096 935 550 550
q20 351 357 230 230
q21 3648 2519 2295 2295
q22 1036 1039 973 973
Total cold run time: 106634 ms
Total hot run time: 34250 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5125 5112 5093 5093
q2 255 340 231 231
q3 2153 2667 2268 2268
q4 1357 1723 1310 1310
q5 4234 4364 4581 4364
q6 213 167 132 132
q7 2066 1993 1917 1917
q8 2827 2574 2607 2574
q9 7375 7353 7348 7348
q10 3047 3279 2849 2849
q11 613 530 502 502
q12 666 794 611 611
q13 3513 3908 3234 3234
q14 307 321 273 273
q15 546 510 495 495
q16 1065 1127 1074 1074
q17 1208 1605 1405 1405
q18 7949 7805 7328 7328
q19 801 786 851 786
q20 1932 1947 1858 1858
q21 4841 4336 4245 4245
q22 1094 1058 988 988
Total cold run time: 53187 ms
Total hot run time: 50885 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57825:
URL: https://github.com/apache/doris/pull/57825#issuecomment-3503951096
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](broker load) Fix strict_mode in broker load not work [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57825:
URL: https://github.com/apache/doris/pull/57825#issuecomment-3502884266
<details>
<summary>ClickBench: <b>Total hot run time: 27.64 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6c781490fbd59503a1afa918f8f26cd4828d5907, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.05
query3 0.25 0.09 0.08
query4 1.60 0.12 0.12
query5 0.27 0.26 0.25
query6 1.17 0.65 0.64
query7 0.03 0.03 0.03
query8 0.05 0.04 0.04
query9 0.60 0.52 0.52
query10 0.57 0.57 0.57
query11 0.17 0.11 0.11
query12 0.15 0.12 0.12
query13 0.61 0.59 0.59
query14 1.02 0.99 1.01
query15 0.85 0.81 0.83
query16 0.39 0.39 0.39
query17 1.08 1.02 1.04
query18 0.21 0.20 0.20
query19 1.85 1.77 1.82
query20 0.01 0.01 0.01
query21 15.45 0.19 0.14
query22 5.09 0.08 0.04
query23 15.65 0.26 0.10
query24 1.77 0.62 0.67
query25 0.08 0.05 0.07
query26 0.15 0.14 0.14
query27 0.07 0.05 0.06
query28 5.22 1.13 0.93
query29 12.60 3.96 3.20
query30 0.28 0.14 0.11
query31 2.82 0.60 0.37
query32 3.24 0.55 0.47
query33 3.06 3.08 3.03
query34 15.87 5.13 4.60
query35 4.58 4.62 4.60
query36 0.68 0.50 0.49
query37 0.09 0.07 0.07
query38 0.07 0.04 0.03
query39 0.04 0.02 0.02
query40 0.17 0.14 0.13
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.18 s
Total hot run time: 27.64 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org