You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/13 18:43:00 UTC
[GitHub] [fineract] vorburger opened a new pull request #764: comment out
flaky SchedulerJobsTest (FINERACT-852)
vorburger opened a new pull request #764: comment out flaky SchedulerJobsTest (FINERACT-852)
URL: https://github.com/apache/fineract/pull/764
Also adds a new assertion for a clearer failure message than the
confusing low-level technical ArrayIndexOutOfBoundsException for
whenever this test will be re-activated later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum merged pull request #764: comment out flaky
SchedulerJobsTest (FINERACT-852)
Posted by GitBox <gi...@apache.org>.
awasum merged pull request #764: comment out flaky SchedulerJobsTest (FINERACT-852)
URL: https://github.com/apache/fineract/pull/764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #764: comment out flaky
SchedulerJobsTest (FINERACT-852)
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #764: comment out flaky SchedulerJobsTest (FINERACT-852)
URL: https://github.com/apache/fineract/pull/764#issuecomment-613475797
> @awasum what's your view re. just ignoring a test?
>
> Ideally we should fix it, of course, but in the meantime... merge this?
Ideally someone more familiar with the code should help us fix this. @Nayan , @nazeer1100126 , @vishwasbabu , @avikganguly01 . Help with resolving a flaky test as seen here: https://github.com/apache/fineract/pull/756 so that we dont comment this out. If we cannot find anyone to help fix this, we may ignore the test by this weekend. Is that too far? Once we ignore this, we may forget that we did like in the other ignored test for data import and others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #764: comment out flaky
SchedulerJobsTest (FINERACT-852)
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #764: comment out flaky SchedulerJobsTest (FINERACT-852)
URL: https://github.com/apache/fineract/pull/764#issuecomment-613052883
@awasum what's your view re. just ignoring a test?
Ideally we should fix it, of course, but in the meantime... merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services