You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/10 05:41:10 UTC
[GitHub] [flink-table-store] tsreaper opened a new pull request #19: [FLINK-26066] Introduce FileStoreRead
tsreaper opened a new pull request #19:
URL: https://github.com/apache/flink-table-store/pull/19
Apart from FileStoreWrite, we also need a FileStoreRead operation to read actual key-values for a specific partition and bucket.
This PR is waiting for #18 . Please review the last commit only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #19: [FLINK-26066] Introduce FileStoreRead
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #19:
URL: https://github.com/apache/flink-table-store/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #19: [FLINK-26066] Introduce FileStoreRead
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #19:
URL: https://github.com/apache/flink-table-store/pull/19#discussion_r808730677
##########
File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreReadImpl.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.file.operation;
+
+import org.apache.flink.table.data.binary.BinaryRowData;
+import org.apache.flink.table.store.file.mergetree.MergeTreeReaderFactory;
+import org.apache.flink.table.store.file.mergetree.compact.IntervalPartition;
+import org.apache.flink.table.store.file.mergetree.sst.SstFileMeta;
+import org.apache.flink.table.store.file.utils.RecordReader;
+
+import java.io.IOException;
+import java.util.List;
+
+/** Default implementation of {@link FileStoreRead}. */
+public class FileStoreReadImpl implements FileStoreRead {
+
+ private final MergeTreeReaderFactory mergeTreeReaderFactory;
Review comment:
Do we really need `MergeTreeReaderFactory` and `MergeTreeWriterFactory` now? Now there is no `MergeTreeFactory` to be shared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #19: [FLINK-26066] Introduce FileStoreRead
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #19:
URL: https://github.com/apache/flink-table-store/pull/19#discussion_r808729514
##########
File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreReadImpl.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.file.operation;
+
+import org.apache.flink.table.data.binary.BinaryRowData;
+import org.apache.flink.table.store.file.mergetree.MergeTreeReaderFactory;
+import org.apache.flink.table.store.file.mergetree.compact.IntervalPartition;
+import org.apache.flink.table.store.file.mergetree.sst.SstFileMeta;
+import org.apache.flink.table.store.file.utils.RecordReader;
+
+import java.io.IOException;
+import java.util.List;
+
+/** Default implementation of {@link FileStoreRead}. */
+public class FileStoreReadImpl implements FileStoreRead {
+
+ private final MergeTreeReaderFactory mergeTreeReaderFactory;
+
+ public FileStoreReadImpl(MergeTreeReaderFactory mergeTreeReaderFactory) {
+ this.mergeTreeReaderFactory = mergeTreeReaderFactory;
+ }
+
+ @Override
+ public void withKeyProjection(int[][] projectedFields) {
+ // TODO
Review comment:
throw exception here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org