You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/27 11:55:46 UTC
[GitHub] [beam] pabloem opened a new pull request, #22469: Improve error message on schema issues
pabloem opened a new pull request, #22469:
URL: https://github.com/apache/beam/pull/22469
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #22469:
URL: https://github.com/apache/beam/pull/22469#issuecomment-1218314689
Noting that tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22469:
URL: https://github.com/apache/beam/pull/22469#issuecomment-1207260458
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #22469:
URL: https://github.com/apache/beam/pull/22469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22469:
URL: https://github.com/apache/beam/pull/22469#issuecomment-1211572261
(or r: @tvalentyn who's dealt with this as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22469:
URL: https://github.com/apache/beam/pull/22469#issuecomment-1208372740
r: @alexvanboxel ? : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22469:
URL: https://github.com/apache/beam/pull/22469#issuecomment-1196682878
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #22469:
URL: https://github.com/apache/beam/pull/22469#discussion_r948247118
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java:
##########
@@ -1440,7 +1440,11 @@ protected InvokeUserCreateInstruction(
}
if (index == null) {
throw new RuntimeException(
- "Creator parameter " + paramName + " Doesn't correspond to a schema field");
+ "Creator parameter "
+ + paramName
+ + " Doesn't correspond to a schema field."
+ + " Make sure that you are compiling with -parameters parameter to include"
+ + " constructor parameter information in class files..");
Review Comment:
```suggestion
+ " constructor parameter information in class files.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22469: Improve error message on schema issues
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22469:
URL: https://github.com/apache/beam/pull/22469#issuecomment-1208387807
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org