svn commit: r720370 - /myfaces/extensions/validator/branches/jsf_1.1/core/src/main/java/org/apache/myfaces/extensions/validator/core/el/DefaultELHelper.java

[gp...@apache.org]

Author: gpetracek
Date: Mon Nov 24 16:42:29 2008
New Revision: 720370

URL: http://svn.apache.org/viewvc?rev=720370&view=rev
Log:
minor changes

Modified:
    myfaces/extensions/validator/branches/jsf_1.1/core/src/main/java/org/apache/myfaces/extensions/validator/core/el/DefaultELHelper.java

Modified: myfaces/extensions/validator/branches/jsf_1.1/core/src/main/java/org/apache/myfaces/extensions/validator/core/el/DefaultELHelper.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/validator/branches/jsf_1.1/core/src/main/java/org/apache/myfaces/extensions/validator/core/el/DefaultELHelper.java?rev=720370&r1=720369&r2=720370&view=diff
==============================================================================
--- myfaces/extensions/validator/branches/jsf_1.1/core/src/main/java/org/apache/myfaces/extensions/validator/core/el/DefaultELHelper.java (original)
+++ myfaces/extensions/validator/branches/jsf_1.1/core/src/main/java/org/apache/myfaces/extensions/validator/core/el/DefaultELHelper.java Mon Nov 24 16:42:29 2008
@@ -18,8 +18,6 @@
  */
 package org.apache.myfaces.extensions.validator.core.el;
 
-import org.apache.myfaces.extensions.validator.internal.ToDo;
-import org.apache.myfaces.extensions.validator.internal.Priority;
 import org.apache.myfaces.extensions.validator.internal.UsageInformation;
 import org.apache.myfaces.extensions.validator.internal.UsageCategory;
 import org.apache.myfaces.extensions.validator.util.ExtValUtils;
@@ -45,7 +43,6 @@
  * it's pluggable in order to support special mechanisms of different technologies (than jsp and facelets)
  * so you can plug in your own impl. which implements a custom workaround (like the facelets workaround of this impl.)
  */
-@ToDo(Priority.MEDIUM)
 @UsageInformation(UsageCategory.INTERNAL)
 public class DefaultELHelper implements ELHelper
 {
@@ -59,8 +56,7 @@
         }
     }
 
-    public Class getTypeOfExpression(FacesContext facesContext,
-                                                    ValueBindingExpression valueBindingExpression)
+    public Class getTypeOfExpression(FacesContext facesContext, ValueBindingExpression valueBindingExpression)
     {
         //due to a restriction with the ri
         Object bean = getValueOfExpression(facesContext, valueBindingExpression);
@@ -73,8 +69,7 @@
         return facesContext.getApplication().getVariableResolver().resolveVariable(facesContext, beanName);
     }
 
-    public Object getValueOfExpression(FacesContext facesContext,
-                                                   ValueBindingExpression valueBindingExpression)
+    public Object getValueOfExpression(FacesContext facesContext, ValueBindingExpression valueBindingExpression)
     {
         return (valueBindingExpression != null) ? facesContext.getApplication()
             .createValueBinding(valueBindingExpression.getExpressionString()).getValue(facesContext) : null;
@@ -85,11 +80,6 @@
         return facesContext.getApplication().createValueBinding(valueBindingExpression) != null;
     }
 
-    private ValueBindingExpression getValueBindingExpression(UIComponent uiComponent)
-    {
-        return getValueBindingExpression(uiComponent, false);
-    }
-
     private ValueBindingExpression getValueBindingExpression(UIComponent uiComponent, boolean allowBlankCharacters)
     {
         String valueBindingExpression = getOriginalValueBindingExpression(uiComponent);
@@ -98,7 +88,11 @@
         //(e.g. for special component libs -> issue with ExtValRendererWrapper#encodeBegin)
         if(valueBindingExpression == null)
         {
-            //TODO logging
+            if(this.logger.isTraceEnabled())
+            {
+                this.logger.trace(
+                        uiComponent.getClass() + " has no value binding - component id: " + uiComponent.getId());
+            }
             return null;
         }
 
@@ -117,7 +111,7 @@
             {
                 if(logger.isWarnEnabled())
                 {
-                    logger.warn("couldn't resolve expression: " + result.getExpressionString());
+                    logger.warn("couldn't resolve expression: " + valueBindingExpression);
                 }
                 return null;
             }