You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/02/17 07:21:09 UTC

[GitHub] [kylin] zzcclp commented on a change in pull request #1583: KYLIN-4903 cache parent datasource to accelerate next layer's cuboid building

zzcclp commented on a change in pull request #1583:
URL: https://github.com/apache/kylin/pull/1583#discussion_r577376293



##########
File path: kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CubeBuildJob.java
##########
@@ -157,7 +157,12 @@ protected void doExecute() throws Exception {
                 logger.info("Triggered cube planner phase one .");
         }
 
-        buildLayoutWithUpdate = new BuildLayoutWithUpdate();
+        if (config.isReuseParentDataSource()) {
+            buildLayerWithUpdate = new BuildLayerWithUpdate();
+        } else {
+            buildLayoutWithUpdate = new BuildLayoutWithUpdate();

Review comment:
       Why needs these two similar Class? It's better to refactor the original class 'BuildLayoutWithUpdate' to support this feature.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org