You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/11 19:10:14 UTC
Review Request 38307: Libprocess: Removed namespace pollution.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38307/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e
3rdparty/libprocess/src/test-master.cpp 5ce91710031e6fce3e1b5791eb782941aef9f10a
3rdparty/libprocess/src/test-slave.cpp 03fa8e61f46dc70647f478c5adef67d8de6cf5c2
3rdparty/libprocess/src/tests/benchmarks.cpp 97c81b8e61a75771e5bf7d46505cec4e0c0f404a
3rdparty/libprocess/src/tests/decoder_tests.cpp 6994fa96d33209f9a367b8c3bb09b0d050023fad
3rdparty/libprocess/src/tests/encoder_tests.cpp 5ad5fd415baca4423c3054a42bd9e175b72153b8
3rdparty/libprocess/src/tests/http_tests.cpp d0b9399d38fa284466a012a21080b1d9007af98b
3rdparty/libprocess/src/tests/io_tests.cpp a7135ee0cfeef7c07ebe41815f47df24dd2b713c
3rdparty/libprocess/src/tests/limiter_tests.cpp ba722509fefc3cd592b6f41d02a0b12d5adf7e00
3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
3rdparty/libprocess/src/tests/mutex_tests.cpp 484727fd36c04f8a3380808d0f75eaad11338331
3rdparty/libprocess/src/tests/owned_tests.cpp 3ef76b8d5426ea10f63bf78b96f45046dd8a955a
3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6
3rdparty/libprocess/src/tests/queue_tests.cpp a6a0dab42ea1674256e8990255bf507aa24f24b8
3rdparty/libprocess/src/tests/reap_tests.cpp 642ab97b28a6085dc9837f14ff36a3124387a03b
3rdparty/libprocess/src/tests/sequence_tests.cpp 88de001aad259c3035f2ff20ed61e7e119a73f54
3rdparty/libprocess/src/tests/shared_tests.cpp 74ea26060ac2800cb98dffbfc90494871d0a9e21
3rdparty/libprocess/src/tests/ssl_client.cpp 9ae59e54bab954b1a931dbc3bd2f1540deb9f5aa
3rdparty/libprocess/src/tests/ssl_tests.cpp ee30a02b112d20bced49ead15447d412f4005a8f
3rdparty/libprocess/src/tests/statistics_tests.cpp 657d27aed18949fa8200236662f2897bdddd2ef4
3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d
3rdparty/libprocess/src/tests/system_tests.cpp 25436ea2e977d667037e2d7344a8804ec35b27b9
3rdparty/libprocess/src/tests/time_tests.cpp 60791ff20671859a0da91524ae8e40ff52c907d0
3rdparty/libprocess/src/tests/timeseries_tests.cpp ec6f4868a65b89244fb4bb8234a77c87831863c3
Diff: https://reviews.apache.org/r/38307/diff/
Testing
-------
make check.
Thanks,
Joris Van Remoortere
Re: Review Request 38307: Libprocess: Removed namespace pollution.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 11, 2015, 6:57 p.m., Joseph Wu wrote:
> > Ship it!
> >
> > I pointed out a bunch of would-be-nice-to-refactor lines. But I don't think it's critical to change them to ship this.
Let's make these changes in a separate patch.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38307/#review98656
-----------------------------------------------------------
On Oct. 14, 2015, 8:39 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38307/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 8:39 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407
> 3rdparty/libprocess/src/test-master.cpp 5ce91710031e6fce3e1b5791eb782941aef9f10a
> 3rdparty/libprocess/src/test-slave.cpp 03fa8e61f46dc70647f478c5adef67d8de6cf5c2
> 3rdparty/libprocess/src/tests/benchmarks.cpp bb9ced8933bf2bb97ae6b3cffdb5528676e53c11
> 3rdparty/libprocess/src/tests/decoder_tests.cpp f1963fdb4c27faa9055e9f9f6edd850cebd15948
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 5ad5fd415baca4423c3054a42bd9e175b72153b8
> 3rdparty/libprocess/src/tests/http_tests.cpp 38f3ad7e46f5b6ef4850cdf7fdcc115715e98472
> 3rdparty/libprocess/src/tests/io_tests.cpp a7135ee0cfeef7c07ebe41815f47df24dd2b713c
> 3rdparty/libprocess/src/tests/limiter_tests.cpp ba722509fefc3cd592b6f41d02a0b12d5adf7e00
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 8f15ee7e89e5346d306df71eb06a7161da13af48
> 3rdparty/libprocess/src/tests/mutex_tests.cpp 484727fd36c04f8a3380808d0f75eaad11338331
> 3rdparty/libprocess/src/tests/owned_tests.cpp 3ef76b8d5426ea10f63bf78b96f45046dd8a955a
> 3rdparty/libprocess/src/tests/process_tests.cpp ffd260a3fa2e49b3de183ba7b392b71afaaba2e5
> 3rdparty/libprocess/src/tests/queue_tests.cpp a6a0dab42ea1674256e8990255bf507aa24f24b8
> 3rdparty/libprocess/src/tests/reap_tests.cpp a844ae2b863b98c49ec8fac79e905b3c04a142fc
> 3rdparty/libprocess/src/tests/sequence_tests.cpp 88de001aad259c3035f2ff20ed61e7e119a73f54
> 3rdparty/libprocess/src/tests/shared_tests.cpp 74ea26060ac2800cb98dffbfc90494871d0a9e21
> 3rdparty/libprocess/src/tests/ssl_client.cpp 9ae59e54bab954b1a931dbc3bd2f1540deb9f5aa
> 3rdparty/libprocess/src/tests/ssl_tests.cpp ee30a02b112d20bced49ead15447d412f4005a8f
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 657d27aed18949fa8200236662f2897bdddd2ef4
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 25d4a7b2fe35fb95f3f19f39bc81d6e50f5c25a3
> 3rdparty/libprocess/src/tests/system_tests.cpp 25436ea2e977d667037e2d7344a8804ec35b27b9
> 3rdparty/libprocess/src/tests/time_tests.cpp 60791ff20671859a0da91524ae8e40ff52c907d0
> 3rdparty/libprocess/src/tests/timeseries_tests.cpp ec6f4868a65b89244fb4bb8234a77c87831863c3
>
> Diff: https://reviews.apache.org/r/38307/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38307: Libprocess: Removed namespace pollution.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38307/#review98656
-----------------------------------------------------------
Ship it!
Ship it!
I pointed out a bunch of would-be-nice-to-refactor lines. But I don't think it's critical to change them to ship this.
3rdparty/libprocess/src/tests/benchmarks.cpp (line 274)
<https://reviews.apache.org/r/38307/#comment155163>
You could change this to:
```
ASSERT_EQ(OK().status, response.status);
```
Which is more consistent with how we use `AWAIT_EXPECT_RESPONSE_STATUS_EQ`.
3rdparty/libprocess/src/tests/http_tests.cpp (line 138)
<https://reviews.apache.org/r/38307/#comment155166>
s/process::http::statuses[401]/Unauthorized().status/?
3rdparty/libprocess/src/tests/http_tests.cpp (line 150)
<https://reviews.apache.org/r/38307/#comment155168>
s/process::http::statuses[401]/Unauthorized().status/?
3rdparty/libprocess/src/tests/http_tests.cpp (line 161)
<https://reviews.apache.org/r/38307/#comment155169>
s/process::http::statuses[200]/OK().status/?
3rdparty/libprocess/src/tests/http_tests.cpp (lines 214 - 215)
<https://reviews.apache.org/r/38307/#comment155172>
Change this to: `AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK.status, future);` ?
3rdparty/libprocess/src/tests/http_tests.cpp (lines 444 - 445)
<https://reviews.apache.org/r/38307/#comment155173>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/http_tests.cpp (lines 452 - 453)
<https://reviews.apache.org/r/38307/#comment155174>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/http_tests.cpp (lines 470 - 471)
<https://reviews.apache.org/r/38307/#comment155178>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/http_tests.cpp (lines 477 - 478)
<https://reviews.apache.org/r/38307/#comment155179>
AWAIT_EXPECT_RESPONSE_STATUS_EQ(Accepted().status, ...)
3rdparty/libprocess/src/tests/http_tests.cpp (lines 618 - 619)
<https://reviews.apache.org/r/38307/#comment155180>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/http_tests.cpp (lines 630 - 631)
<https://reviews.apache.org/r/38307/#comment155181>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/http_tests.cpp (lines 656 - 657)
<https://reviews.apache.org/r/38307/#comment155182>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 1640 - 1641)
<https://reviews.apache.org/r/38307/#comment155183>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 1973 - 1974)
<https://reviews.apache.org/r/38307/#comment155184>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2032 - 2033)
<https://reviews.apache.org/r/38307/#comment155185>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2042 - 2043)
<https://reviews.apache.org/r/38307/#comment155188>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2048 - 2049)
<https://reviews.apache.org/r/38307/#comment155187>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2056 - 2057)
<https://reviews.apache.org/r/38307/#comment155189>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2066 - 2067)
<https://reviews.apache.org/r/38307/#comment155191>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2074 - 2075)
<https://reviews.apache.org/r/38307/#comment155190>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2102 - 2103)
<https://reviews.apache.org/r/38307/#comment155192>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2107 - 2108)
<https://reviews.apache.org/r/38307/#comment155193>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2117 - 2118)
<https://reviews.apache.org/r/38307/#comment155194>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/process_tests.cpp (lines 2125 - 2126)
<https://reviews.apache.org/r/38307/#comment155195>
AWAIT_EXPECT_RESPONSE_STATUS_EQ
3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 666 - 667)
<https://reviews.apache.org/r/38307/#comment155200>
Could remove the double-await on the same future.
3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 707 - 708)
<https://reviews.apache.org/r/38307/#comment155201>
Double await here.
- Joseph Wu
On Sept. 11, 2015, 10:10 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38307/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 10:10 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e
> 3rdparty/libprocess/src/test-master.cpp 5ce91710031e6fce3e1b5791eb782941aef9f10a
> 3rdparty/libprocess/src/test-slave.cpp 03fa8e61f46dc70647f478c5adef67d8de6cf5c2
> 3rdparty/libprocess/src/tests/benchmarks.cpp 97c81b8e61a75771e5bf7d46505cec4e0c0f404a
> 3rdparty/libprocess/src/tests/decoder_tests.cpp 6994fa96d33209f9a367b8c3bb09b0d050023fad
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 5ad5fd415baca4423c3054a42bd9e175b72153b8
> 3rdparty/libprocess/src/tests/http_tests.cpp d0b9399d38fa284466a012a21080b1d9007af98b
> 3rdparty/libprocess/src/tests/io_tests.cpp a7135ee0cfeef7c07ebe41815f47df24dd2b713c
> 3rdparty/libprocess/src/tests/limiter_tests.cpp ba722509fefc3cd592b6f41d02a0b12d5adf7e00
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
> 3rdparty/libprocess/src/tests/mutex_tests.cpp 484727fd36c04f8a3380808d0f75eaad11338331
> 3rdparty/libprocess/src/tests/owned_tests.cpp 3ef76b8d5426ea10f63bf78b96f45046dd8a955a
> 3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6
> 3rdparty/libprocess/src/tests/queue_tests.cpp a6a0dab42ea1674256e8990255bf507aa24f24b8
> 3rdparty/libprocess/src/tests/reap_tests.cpp 642ab97b28a6085dc9837f14ff36a3124387a03b
> 3rdparty/libprocess/src/tests/sequence_tests.cpp 88de001aad259c3035f2ff20ed61e7e119a73f54
> 3rdparty/libprocess/src/tests/shared_tests.cpp 74ea26060ac2800cb98dffbfc90494871d0a9e21
> 3rdparty/libprocess/src/tests/ssl_client.cpp 9ae59e54bab954b1a931dbc3bd2f1540deb9f5aa
> 3rdparty/libprocess/src/tests/ssl_tests.cpp ee30a02b112d20bced49ead15447d412f4005a8f
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 657d27aed18949fa8200236662f2897bdddd2ef4
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d
> 3rdparty/libprocess/src/tests/system_tests.cpp 25436ea2e977d667037e2d7344a8804ec35b27b9
> 3rdparty/libprocess/src/tests/time_tests.cpp 60791ff20671859a0da91524ae8e40ff52c907d0
> 3rdparty/libprocess/src/tests/timeseries_tests.cpp ec6f4868a65b89244fb4bb8234a77c87831863c3
>
> Diff: https://reviews.apache.org/r/38307/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38307: Libprocess: Removed namespace pollution.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38307/
-----------------------------------------------------------
(Updated Oct. 14, 2015, 8:39 a.m.)
Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and Till Toenshoff.
Changes
-------
updated.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407
3rdparty/libprocess/src/test-master.cpp 5ce91710031e6fce3e1b5791eb782941aef9f10a
3rdparty/libprocess/src/test-slave.cpp 03fa8e61f46dc70647f478c5adef67d8de6cf5c2
3rdparty/libprocess/src/tests/benchmarks.cpp bb9ced8933bf2bb97ae6b3cffdb5528676e53c11
3rdparty/libprocess/src/tests/decoder_tests.cpp f1963fdb4c27faa9055e9f9f6edd850cebd15948
3rdparty/libprocess/src/tests/encoder_tests.cpp 5ad5fd415baca4423c3054a42bd9e175b72153b8
3rdparty/libprocess/src/tests/http_tests.cpp 38f3ad7e46f5b6ef4850cdf7fdcc115715e98472
3rdparty/libprocess/src/tests/io_tests.cpp a7135ee0cfeef7c07ebe41815f47df24dd2b713c
3rdparty/libprocess/src/tests/limiter_tests.cpp ba722509fefc3cd592b6f41d02a0b12d5adf7e00
3rdparty/libprocess/src/tests/metrics_tests.cpp 8f15ee7e89e5346d306df71eb06a7161da13af48
3rdparty/libprocess/src/tests/mutex_tests.cpp 484727fd36c04f8a3380808d0f75eaad11338331
3rdparty/libprocess/src/tests/owned_tests.cpp 3ef76b8d5426ea10f63bf78b96f45046dd8a955a
3rdparty/libprocess/src/tests/process_tests.cpp ffd260a3fa2e49b3de183ba7b392b71afaaba2e5
3rdparty/libprocess/src/tests/queue_tests.cpp a6a0dab42ea1674256e8990255bf507aa24f24b8
3rdparty/libprocess/src/tests/reap_tests.cpp a844ae2b863b98c49ec8fac79e905b3c04a142fc
3rdparty/libprocess/src/tests/sequence_tests.cpp 88de001aad259c3035f2ff20ed61e7e119a73f54
3rdparty/libprocess/src/tests/shared_tests.cpp 74ea26060ac2800cb98dffbfc90494871d0a9e21
3rdparty/libprocess/src/tests/ssl_client.cpp 9ae59e54bab954b1a931dbc3bd2f1540deb9f5aa
3rdparty/libprocess/src/tests/ssl_tests.cpp ee30a02b112d20bced49ead15447d412f4005a8f
3rdparty/libprocess/src/tests/statistics_tests.cpp 657d27aed18949fa8200236662f2897bdddd2ef4
3rdparty/libprocess/src/tests/subprocess_tests.cpp 25d4a7b2fe35fb95f3f19f39bc81d6e50f5c25a3
3rdparty/libprocess/src/tests/system_tests.cpp 25436ea2e977d667037e2d7344a8804ec35b27b9
3rdparty/libprocess/src/tests/time_tests.cpp 60791ff20671859a0da91524ae8e40ff52c907d0
3rdparty/libprocess/src/tests/timeseries_tests.cpp ec6f4868a65b89244fb4bb8234a77c87831863c3
Diff: https://reviews.apache.org/r/38307/diff/
Testing
-------
make check.
Thanks,
Joris Van Remoortere
Re: Review Request 38307: Libprocess: Removed namespace pollution.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38307/#review98720
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38305, 38306, 38308, 38307]
All tests passed.
- Mesos ReviewBot
On Sept. 11, 2015, 5:10 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38307/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 5:10 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e
> 3rdparty/libprocess/src/test-master.cpp 5ce91710031e6fce3e1b5791eb782941aef9f10a
> 3rdparty/libprocess/src/test-slave.cpp 03fa8e61f46dc70647f478c5adef67d8de6cf5c2
> 3rdparty/libprocess/src/tests/benchmarks.cpp 97c81b8e61a75771e5bf7d46505cec4e0c0f404a
> 3rdparty/libprocess/src/tests/decoder_tests.cpp 6994fa96d33209f9a367b8c3bb09b0d050023fad
> 3rdparty/libprocess/src/tests/encoder_tests.cpp 5ad5fd415baca4423c3054a42bd9e175b72153b8
> 3rdparty/libprocess/src/tests/http_tests.cpp d0b9399d38fa284466a012a21080b1d9007af98b
> 3rdparty/libprocess/src/tests/io_tests.cpp a7135ee0cfeef7c07ebe41815f47df24dd2b713c
> 3rdparty/libprocess/src/tests/limiter_tests.cpp ba722509fefc3cd592b6f41d02a0b12d5adf7e00
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
> 3rdparty/libprocess/src/tests/mutex_tests.cpp 484727fd36c04f8a3380808d0f75eaad11338331
> 3rdparty/libprocess/src/tests/owned_tests.cpp 3ef76b8d5426ea10f63bf78b96f45046dd8a955a
> 3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6
> 3rdparty/libprocess/src/tests/queue_tests.cpp a6a0dab42ea1674256e8990255bf507aa24f24b8
> 3rdparty/libprocess/src/tests/reap_tests.cpp 642ab97b28a6085dc9837f14ff36a3124387a03b
> 3rdparty/libprocess/src/tests/sequence_tests.cpp 88de001aad259c3035f2ff20ed61e7e119a73f54
> 3rdparty/libprocess/src/tests/shared_tests.cpp 74ea26060ac2800cb98dffbfc90494871d0a9e21
> 3rdparty/libprocess/src/tests/ssl_client.cpp 9ae59e54bab954b1a931dbc3bd2f1540deb9f5aa
> 3rdparty/libprocess/src/tests/ssl_tests.cpp ee30a02b112d20bced49ead15447d412f4005a8f
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 657d27aed18949fa8200236662f2897bdddd2ef4
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d
> 3rdparty/libprocess/src/tests/system_tests.cpp 25436ea2e977d667037e2d7344a8804ec35b27b9
> 3rdparty/libprocess/src/tests/time_tests.cpp 60791ff20671859a0da91524ae8e40ff52c907d0
> 3rdparty/libprocess/src/tests/timeseries_tests.cpp ec6f4868a65b89244fb4bb8234a77c87831863c3
>
> Diff: https://reviews.apache.org/r/38307/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>