You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2015/09/19 15:35:14 UTC

ant git commit: ignores zip64Mode for manifest-only jars

Repository: ant
Updated Branches:
  refs/heads/master a76cf99dd -> 76455a35c


<jar> ignores zip64Mode for manifest-only jars

Bugzilla Report 58428


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/76455a35
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/76455a35
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/76455a35

Branch: refs/heads/master
Commit: 76455a35cb894dde4142555892bb30a4cee495f1
Parents: a76cf99
Author: Stefan Bodewig <bo...@apache.org>
Authored: Sat Sep 19 15:34:23 2015 +0200
Committer: Stefan Bodewig <bo...@apache.org>
Committed: Sat Sep 19 15:34:23 2015 +0200

----------------------------------------------------------------------
 WHATSNEW                                        | 5 +++++
 src/main/org/apache/tools/ant/taskdefs/Jar.java | 1 +
 2 files changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/76455a35/WHATSNEW
----------------------------------------------------------------------
diff --git a/WHATSNEW b/WHATSNEW
index 2ff6ee4..18708f9 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -14,6 +14,11 @@ Fixed bugs:
 
  * <gunzip> and <bunzip2> didn't work for non-filesystem resources.
 
+ * <jar> ignored the zip64Mode attribute when creating manifest-only
+   jars.  This resulted in jar files that couldn't be read by Java5.
+   Bugzilla Report 58428
+
+
 Other changes:
 --------------
 

http://git-wip-us.apache.org/repos/asf/ant/blob/76455a35/src/main/org/apache/tools/ant/taskdefs/Jar.java
----------------------------------------------------------------------
diff --git a/src/main/org/apache/tools/ant/taskdefs/Jar.java b/src/main/org/apache/tools/ant/taskdefs/Jar.java
index c2c0f0e..28738b1 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Jar.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Jar.java
@@ -914,6 +914,7 @@ public class Jar extends Zip {
             zOut = new ZipOutputStream(getDestFile());
 
             zOut.setEncoding(getEncoding());
+            zOut.setUseZip64(getZip64Mode().getMode());
             if (isCompress()) {
                 zOut.setMethod(ZipOutputStream.DEFLATED);
             } else {