[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2912: [GOBBLIN-1072] Add sliding window to protect AutoScaling from fluctuation of number of active Helix partitions

[GitBox <gi...@apache.org>]

autumnust commented on a change in pull request #2912: [GOBBLIN-1072] Add sliding window to protect AutoScaling from fluctuation of number of active Helix partitions
URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389188549
 
 

 ##########
 File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java
 ##########
 @@ -196,9 +207,84 @@ void runInternal() {
       // adjust the number of target containers based on the configured min and max container values.
       numTargetContainers = Math.max(this.minContainers, Math.min(this.maxContainers, numTargetContainers));
 
+      slidingFixedWindow.add(numTargetContainers);
 
 Review comment:
   Discussed offline. Agreed on new way to tag an instance as "unused" and be more conservative on container release. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services