You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zzzzming95 (via GitHub)" <gi...@apache.org> on 2023/03/01 05:25:22 UTC

[GitHub] [spark] zzzzming95 commented on pull request #40196: [SPARK-42603][SQL] Set spark.sql.legacy.createHiveTableByDefault to false.

zzzzming95 commented on PR #40196:
URL: https://github.com/apache/spark/pull/40196#issuecomment-1449371301

   In fact, the describtion of `spark.sql.legacy.createHiveTableByDefault` from `SQLConf` is wrong.
   
   In my test, the hive table format depends on the conf `hive.default.fileformat` when set `spark.sql.legacy.createHiveTableByDefault` is true . And if `spark.sql.legacy.createHiveTableByDefault` is false, it hive table format depends on the conf `spark.sql.sources.default` .
   
   So maybe we should fix the wrong describtion of `spark.sql.legacy.createHiveTableByDefault`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org