[GitHub] [guacamole-server] necouchman commented on a change in pull request #238: GUACAMOLE-625: Included Latin American keymap

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #238: GUACAMOLE-625: Included Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/238#discussion_r326411378
 
 

 ##########
 File path: src/protocols/rdp/Makefile.am
 ##########
 @@ -268,6 +268,7 @@ rdp_keymaps =                   \
     $(srcdir)/keymaps/en_gb_qwerty.keymap \
     $(srcdir)/keymaps/en_us_qwerty.keymap \
     $(srcdir)/keymaps/es_es_qwerty.keymap \
+    $(srcdir)/keymaps/latam_qwerty.keymap \
 
 Review comment:
   A couple of things, here:
   - Is "latam" actually the proper identifier for this keyboard layout?  I would suspect something following existing patterns - like "es_la_qwerty" or the like?  I don't know if there's an official standard for this or just what we're calling it in Guacamole, but it should be consistent.
   - It should also be organized alphabetically - so if "es_la_qwerty" is the correct name for the layout, this is the correct spot - if "latam_qwerty" is correct, then it should be down a little further in the file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services