You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/04/07 18:32:36 UTC
[GitHub] [samza] Sanil15 commented on a change in pull request #1333:
SAMZA-2497: Close MetadataResourceUtil when job is stopped
Sanil15 commented on a change in pull request #1333: SAMZA-2497: Close MetadataResourceUtil when job is stopped
URL: https://github.com/apache/samza/pull/1333#discussion_r405025357
##########
File path: samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinator.java
##########
@@ -312,7 +313,7 @@ JobModel readJobModelFromMetadataStore(String zkJobModelVersion) {
@VisibleForTesting
void loadMetadataResources(JobModel jobModel) {
try {
- MetadataResourceUtil metadataResourceUtil = createMetadataResourceUtil(jobModel, config);
+ metadataResourceUtil = createMetadataResourceUtil(jobModel, config);
Review comment:
Where is `metadataResourceUtil#stop` is being stopped for ZkJobCoordinator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services