You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ggbaro (via GitHub)" <gi...@apache.org> on 2023/09/19 12:06:11 UTC

[GitHub] [superset] ggbaro opened a new issue, #25339: Update flask-caching version to 2.0+ to avoid breaking redis cache

ggbaro opened a new issue, #25339:
URL: https://github.com/apache/superset/issues/25339

   A clear and concise description of what the bug is.
   
   #### How to reproduce the bug
   
   If we have flask-caching=~1.11.1 and cachelib>9 (flask-caching did not pin down cahcelib dependency until 2.0, so it's very likely to happen...), we end up with this https://github.com/pallets-eco/flask-caching/issues/381
   
   caused by this very line:
   https://github.com/pallets-eco/flask-caching/blob/ac13e01baa11d65c68dcba64f99ccaafd9b5419c/src/flask_caching/backends/rediscache.py#L62
   
   The fix might be as small as this (even if I'd like to test more in depth): https://github.com/ggbaro/superset-ggbaro/commit/185e59ea80901600d5dc88ddc1b67e1f191c9504
   Do you suggest to make a PR?
   
   ### Expected results
   
   App starts normally
   
   ### Actual results
   
   flask-caching breaks with redis cache
   
   ### Environment
   
   (please complete the following information):
   
   - browser type and version:
   - superset version: `>=2`
   - python version: `3.9 & 3.10`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
     - see  https://github.com/pallets-eco/flask-caching/issues/381
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ggbaro commented on issue #25339: Update flask-caching version to 2.0+ to avoid breaking redis cache

Posted by "ggbaro (via GitHub)" <gi...@apache.org>.
ggbaro commented on issue #25339:
URL: https://github.com/apache/superset/issues/25339#issuecomment-1727140507

   > Having the same issue and seen the issue in the Slack.
   > 
   > Hopefully there will be a fix soon
   
   In the meantime, just add `cachelib<9` to your local dependencies 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Update flask-caching version to 2.0+ to avoid breaking redis cache [superset]

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley closed issue #25339: Update flask-caching version to 2.0+ to avoid breaking redis cache
URL: https://github.com/apache/superset/issues/25339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] lf-floriandin commented on issue #25339: Update flask-caching version to 2.0+ to avoid breaking redis cache

Posted by "lf-floriandin (via GitHub)" <gi...@apache.org>.
lf-floriandin commented on issue #25339:
URL: https://github.com/apache/superset/issues/25339#issuecomment-1727132387

   Having the same issue and seen the issue in the Slack.
   Hopefully there will be a fix soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org