[GitHub] [kyuubi] bowenliang123 commented on pull request #4777: Make EventHandler auto-closeable and de-register all event handlers when stopping server

["bowenliang123 (via GitHub)" <gi...@apache.org>]

bowenliang123 commented on PR #4777:
URL: https://github.com/apache/kyuubi/pull/4777#issuecomment-1525633602

   > Can we add some tests?
   
   I think the changes in `[ServerJsonLoggingEventHandlerSuite.scala](https://github.com/apache/kyuubi/pull/4777/files#diff-91972dfd64cc4b9aa688957a9b4e2a78f328a1cdc26beae3048a8a62fb9b9a10R201)` reflects the situations. It is equivalent to testing both no messages after clearing up the event handlers and receiving messages by re-registering event handlers again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org